Make # abs tol compare over the complex numbers #38433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbraun
force-pushed
the
gh-36631-abs-tol-on-complex-domain
branch
from
0ba5432
to
c63a445
Compare
|
Documentation preview for this PR (built with commit d06e94b; changes) is ready! 🎉 |
|
Test failure in sagemath-categories |
vbraun
force-pushed
the
gh-36631-abs-tol-on-complex-domain
branch
from
c63a445
to
e8d8128
Compare
vbraun
force-pushed
the
gh-36631-abs-tol-on-complex-domain
branch
from
e8d8128
to
d06e94b
Compare
|
All checks passed and the github-actions bot removed the positive review tag? 🤷 |
It does that on pushes. It has nothing to do with the checks. |
For calculations over complex numbers that generate numeric noise, one tends to create small but non-zero imaginary parts. This PR updates the "# abs tol" tolerance setting to work over the complex numbers, as the "abs" suggests complex numbers. The real and imaginary parts are compared separately. The ordinary "# tol" and "# rel tol" are left as is. Fixes sagemath#36631
vbraun
force-pushed
the
gh-36631-abs-tol-on-complex-domain
branch
from
d06e94b
to
1cca0f6
Compare
|
Merge conflict fixed |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 3, 2024
For calculations over complex numbers that generate numeric noise, one tends to create small but non-zero imaginary parts. This PR updates the "# abs tol" tolerance setting to work over the complex numbers, as the "abs" suggests complex numbers. The real and imaginary parts are compared separately. The ordinary "# tol" and "# rel tol" are left as is. Fixes sagemath#36631 URL: sagemath#38433 Reported by: Volker Braun Reviewer(s): Dima Pasechnik
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 5, 2024
For calculations over complex numbers that generate numeric noise, one tends to create small but non-zero imaginary parts. This PR updates the "# abs tol" tolerance setting to work over the complex numbers, as the "abs" suggests complex numbers. The real and imaginary parts are compared separately. The ordinary "# tol" and "# rel tol" are left as is. Fixes sagemath#36631 URL: sagemath#38433 Reported by: Volker Braun Reviewer(s): Dima Pasechnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For calculations over complex numbers that generate numeric noise, one tends to create small but non-zero imaginary parts. This PR updates the "# abs tol" tolerance setting to work over the complex numbers, as the "abs" suggests complex numbers. The real and imaginary parts are compared separately.
The ordinary "# tol" and "# rel tol" are left as is.
Fixes #36631