-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add method is_edge_cut
to graphs
#38435
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview for this PR (built with commit 56f380b; changes) is ready! 🎉 |
dcoudert
force-pushed
the
graphs/is_edge_cut
branch
from
August 6, 2024 08:34
edfbff0
to
5cab21d
Compare
kwankyu
reviewed
Aug 28, 2024
kwankyu
reviewed
Aug 28, 2024
kwankyu
reviewed
Aug 28, 2024
kwankyu
reviewed
Aug 28, 2024
kwankyu
reviewed
Aug 28, 2024
kwankyu
reviewed
Aug 28, 2024
kwankyu
reviewed
Aug 29, 2024
kwankyu
reviewed
Aug 29, 2024
kwankyu
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM.
Thank you for the review. |
I have only rebased the PR on last beta. I set it back to positive review. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 5, 2024
Similarly to sagemath#38418, this PR adds a method to check whether a set of edges forms an edge cut of the (di)graph, that is if the removal of these edges increases the number of (weakly) connected components. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38435 Reported by: David Coudert Reviewer(s): David Coudert, Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 6, 2024
Similarly to sagemath#38418, this PR adds a method to check whether a set of edges forms an edge cut of the (di)graph, that is if the removal of these edges increases the number of (weakly) connected components. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38435 Reported by: David Coudert Reviewer(s): David Coudert, Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 8, 2024
Similarly to sagemath#38418, this PR adds a method to check whether a set of edges forms an edge cut of the (di)graph, that is if the removal of these edges increases the number of (weakly) connected components. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38435 Reported by: David Coudert Reviewer(s): David Coudert, Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 8, 2024
Similarly to sagemath#38418, this PR adds a method to check whether a set of edges forms an edge cut of the (di)graph, that is if the removal of these edges increases the number of (weakly) connected components. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38435 Reported by: David Coudert Reviewer(s): David Coudert, Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 10, 2024
Similarly to sagemath#38418, this PR adds a method to check whether a set of edges forms an edge cut of the (di)graph, that is if the removal of these edges increases the number of (weakly) connected components. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38435 Reported by: David Coudert Reviewer(s): David Coudert, Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 12, 2024
Similarly to sagemath#38418, this PR adds a method to check whether a set of edges forms an edge cut of the (di)graph, that is if the removal of these edges increases the number of (weakly) connected components. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38435 Reported by: David Coudert Reviewer(s): David Coudert, Kwankyu Lee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to #38418, this PR adds a method to check whether a set of edges forms an edge cut of the (di)graph, that is if the removal of these edges increases the number of (weakly) connected components.
📝 Checklist
⌛ Dependencies