Hashing affine group elements #38508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit b10beae; changes) is ready! 🎉 |
fchapoton
reviewed
Aug 14, 2024
mkoeppe
reviewed
Aug 20, 2024
| @@ -45,6 +45,7 @@ | |||
| from sage.structure.element import MultiplicativeGroupElement | |||
| from sage.structure.richcmp import richcmp, richcmp_not_equal | |||
|
|
|||
| from copy import copy | |||
There was a problem hiding this comment.
imports from stdlib go to the top of the file, before from sage... imports
mkoeppe
reviewed
Aug 20, 2024
| sage: hash(g) == hash(copy(g)) | ||
| True | ||
| sage: f = g * h | ||
| sage: hash(f) == hash((f.A(), f.b())) |
There was a problem hiding this comment.
I don't think it's a good idea to pin this implementation detail in a doctest
tscrim
force-pushed
the
groups/hashable_affine-38381
branch
from
bcb7cd4 to
f3ec5b3
Compare
|
I've addressed the reviewer comments (although I disagree with the detail in the doctest; someone who is changing the hash will clearly see the doctest needs to be updated, doctests are not, and should not be, fixed forever). @fchapoton Could you do the final review here? Should be quick. |
fchapoton
reviewed
Nov 28, 2024
|
Thank you. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 6, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Fixes sagemath#38381 and makes sure the defining parts of the group element are immutable. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38508 Reported by: Travis Scrimshaw Reviewer(s): Frédéric Chapoton, Matthias Köppe, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 8, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Fixes sagemath#38381 and makes sure the defining parts of the group element are immutable. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38508 Reported by: Travis Scrimshaw Reviewer(s): Frédéric Chapoton, Matthias Köppe, Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38381 and makes sure the defining parts of the group element are immutable.
📝 Checklist
⌛ Dependencies