Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #38832 about canonical_label in bipartite graphs #38842

Merged
merged 3 commits into from
Nov 3, 2024

Conversation

dcoudert
Copy link
Contributor

Fixes #38832.

We fix call to canonical_label on BipartiteGraph when parameter partition is None.

sage: G = BipartiteGraph(matrix([[1, 1], [1, 1]]))
sage: C = G.canonical_label()
sage: C.left, C.right
({0, 1}, {2, 3})

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Oct 23, 2024

Documentation preview for this PR (built with commit ddad107; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 26, 2024
… bipartite graphs

    
Fixes sagemath#38832.

We fix call to `canonical_label` on `BipartiteGraph` when parameter
`partition` is `None`.
```py
sage: G = BipartiteGraph(matrix([[1, 1], [1, 1]]))
sage: C = G.canonical_label()
sage: C.left, C.right
({0, 1}, {2, 3})
```


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38842
Reported by: David Coudert
Reviewer(s): Kwankyu Lee
@vbraun vbraun merged commit f2780d8 into sagemath:develop Nov 3, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.canonical_label() errors on bipartite graphs when partition= is not specified
3 participants