Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Meson CI workflow #39176

Merged
merged 2 commits into from
Jan 4, 2025
Merged

Improve Meson CI workflow #39176

merged 2 commits into from
Jan 4, 2025

Conversation

tobiasdiez
Copy link
Contributor

Small improvements to the Meson-based CI workflow:

  • Add check that all dependencies are installed via conda (and are not pulled-in from pypi). This copies the same check from the conda workflow, as a preparation to delete the latter.
  • In case of error, upload the meson build logs to make it easier to investigate errors.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 20, 2024 •
edited
Loading

Documentation preview for this PR (built with commit f89f2f9; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@tobiasdiez tobiasdiez marked this pull request as ready for review December 20, 2024 14:33
@user202729
Copy link
Contributor

how does the second step work (where is the log uploaded to anyway? Isn't it already obtainable by "Download log archive" button?)

@tobiasdiez
Copy link
Contributor Author

how does the second step work (where is the log uploaded to anyway? Isn't it already obtainable by "Download log archive" button?)

You see it at the bottom of https://github.com/sagemath/sage/actions/runs/12429896885?pr=39176 and it contains more internal information about the meson run that are normally not printed to stdout.

@tobiasdiez tobiasdiez requested a review from dimpase December 24, 2024 05:22
@tobiasdiez
Copy link
Contributor Author

@user202729 are you happy with these changes? If yes, could you set it to positive review review (or I will do it for you if you don't yet have been accepted into the triage team).

@user202729
Copy link
Contributor

I just notice that ci-conda.yml already use --no-deps. So this PR adds the same thing to ci-meson.yml.

Comparing the difference, ci-conda.yml has if: success() || failure() (which is equivalent to if: '!cancelled()' but is more confusing) — I can't really tell which option is better, but anyway.

Anyway… looks like (I didn't test) the only difference is whether ./bootstrap exists. Apart from that looks like there are a bunch of irrelevant differences (e.g. one uses -p0, the other uses -p4.)

I think it would be cleaner to maintain if they're merged.

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 1, 2025
sagemathgh-39176: Improve Meson CI workflow
1c6a316 
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Small improvements to the Meson-based CI workflow:
- Add check that all dependencies are installed via conda (and are not
pulled-in from pypi). This copies the same check from the conda
workflow, as a preparation to delete the latter.
- In case of error, upload the meson build logs to make it easier to
investigate errors.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39176
Reported by: Tobias Diez
Reviewer(s): Dima Pasechnik, user202729
@tobiasdiez
Copy link
Contributor Author

The plan is to delete the conda ci workflow very soon (as part of retiring the setuptools-based installation). Only thing missing for this is #38879.

@user202729 user202729 mentioned this pull request Jan 2, 2025
Open
2 tasks
@vbraun vbraun merged commit 598ba04 into sagemath:develop Jan 4, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@user202729 user202729 user202729 approved these changes

@dimpase dimpase dimpase approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tobiasdiez @user202729 @dimpase @vbraun