Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add parameter immutable to some graph products in sage/graphs/generic_graph.py #39285

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

add parameter immutable to some graph products in sage/graphs/generic_graph.py #39285

wants to merge 4 commits into from

Conversation

dcoudert
Copy link
Contributor

@dcoudert dcoudert commented Jan 5, 2025

Following #39280 and discussions in #39177, we add parameter immutable to some graph product operations defined in sage/graphs/generic_graph.py:

  • cartesian_product
  • tensor_product
  • lexicographic_product
  • strong_product
  • disjunctive_product

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@dcoudert dcoudert self-assigned this Jan 5, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2025 •
edited
Loading

Documentation preview for this PR (built with commit 1d96578; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@dcoudert dcoudert mentioned this pull request Jan 7, 2025
Open
5 tasks
fchapoton
fchapoton approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. One could ask which one of immutable or mutable should have priority when factors have different states. I am not sure there is a mathematical prefrered answer.

@dcoudert
Copy link
Contributor Author

I'm not sure either which one should have priority. Same for the default value of parameter immutable. The first step is to ensure that all methods returning a graph have the parameter and that the behavior is consistent. Then we can change the default value subject to some deprecation period.

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 28, 2025
sagemathgh-39285: add parameter immutable to some graph products in…
e61f9b8 
… `sage/graphs/generic_graph.py`

    
Following sagemath#39280 and discussions in sagemath#39177, we add parameter `immutable`
to some graph product operations defined in
`sage/graphs/generic_graph.py`:
- `cartesian_product`
- `tensor_product`
- `lexicographic_product`
- `strong_product`
- `disjunctive_product`


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39285
Reported by: David Coudert
Reviewer(s): David Coudert, Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 29, 2025
sagemathgh-39285: add parameter immutable to some graph products in…
bdf44ff 
… `sage/graphs/generic_graph.py`

    
Following sagemath#39280 and discussions in sagemath#39177, we add parameter `immutable`
to some graph product operations defined in
`sage/graphs/generic_graph.py`:
- `cartesian_product`
- `tensor_product`
- `lexicographic_product`
- `strong_product`
- `disjunctive_product`


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39285
Reported by: David Coudert
Reviewer(s): David Coudert, Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 30, 2025
sagemathgh-39285: add parameter immutable to some graph products in…
d261bfe 
… `sage/graphs/generic_graph.py`

    
Following sagemath#39280 and discussions in sagemath#39177, we add parameter `immutable`
to some graph product operations defined in
`sage/graphs/generic_graph.py`:
- `cartesian_product`
- `tensor_product`
- `lexicographic_product`
- `strong_product`
- `disjunctive_product`


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39285
Reported by: David Coudert
Reviewer(s): David Coudert, Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 31, 2025
sagemathgh-39285: add parameter immutable to some graph products in…
af6adb9 
… `sage/graphs/generic_graph.py`

    
Following sagemath#39280 and discussions in sagemath#39177, we add parameter `immutable`
to some graph product operations defined in
`sage/graphs/generic_graph.py`:
- `cartesian_product`
- `tensor_product`
- `lexicographic_product`
- `strong_product`
- `disjunctive_product`


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39285
Reported by: David Coudert
Reviewer(s): David Coudert, Frédéric Chapoton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchapoton fchapoton fchapoton approved these changes

Assignees

@dcoudert dcoudert

Labels
c: graph theory s: positive review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcoudert @fchapoton