Hide more chronic diff on CI #39542
Merged
Hide more chronic diff on CI #39542
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 5e6c51e; changes) is ready! 🎉 |
fchapoton
approved these changes
Feb 21, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 22, 2025
When you click on the "changes is ready!" button posted by github- actions, sometimes when a new code block is added/removed, a lot of irrelevant diff is shown. This pull request fixes it. Note: looks like the diff is against the last release, so we can't test this until after the next release. But the change looks simple enough that it can't have any bug… right. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39542 Reported by: user202729 Reviewer(s): Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 24, 2025
When you click on the "changes is ready!" button posted by github- actions, sometimes when a new code block is added/removed, a lot of irrelevant diff is shown. This pull request fixes it. Note: looks like the diff is against the last release, so we can't test this until after the next release. But the change looks simple enough that it can't have any bug… right. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39542 Reported by: user202729 Reviewer(s): Frédéric Chapoton
Very bad news: the diff baseline is not updated, and now the CHANGES.html is massive for the obvious reason. The code is duplicated so…
Time to refactor the thing to avoid code duplication. |
|
Follow-up in #39622 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you click on the "changes is ready!" button posted by github-actions, sometimes when a new code block is added/removed, a lot of irrelevant diff is shown. This pull request fixes it.
Note: looks like the diff is against the last release, so we can't test this until after the next release. But the change looks simple enough that it can't have any bug… right.
📝 Checklist
⌛ Dependencies