Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change some instances of "gens" method to return tuples #39572

Merged
merged 7 commits into from
Feb 28, 2025

Conversation

pyrusbrawler64
Copy link
Contributor

Contributes to #34120

As noted in the referenced issue. most instances of the "gens" method return tuples, so the few instances of the method which return lists instead should be modified to return tuples. This pull request handles the following bullet points from the issue:

  • SymmetricReductionStrategy in src/sage/rings/polynomial/symmetric_reduction.pyx
  • EllipticCurve_number_field in src/sage/schemes/elliptic_curves/ell_number_field.py
  • SpecialCubicQuotientRing in src/sage/schemes/hyperelliptic_curves/monsky_washnitzer.py

In each case the gens method from the mentioned class has been modified to return a tuple instead of a list and doctests have been updated appropriately.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

Documentation preview for this PR (built with commit b9275d7; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@vincentmacri vincentmacri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbraun vbraun merged commit 1bc98df into sagemath:develop Feb 28, 2025
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants