Change some instances of "gens" method to return tuples #39572
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #34120
As noted in the referenced issue. most instances of the "gens" method return tuples, so the few instances of the method which return lists instead should be modified to return tuples. This pull request handles the following bullet points from the issue:
SymmetricReductionStrategy
insrc/sage/rings/polynomial/symmetric_reduction.pyx
EllipticCurve_number_field
insrc/sage/schemes/elliptic_curves/ell_number_field.py
SpecialCubicQuotientRing
insrc/sage/schemes/hyperelliptic_curves/monsky_washnitzer.py
In each case the gens method from the mentioned class has been modified to return a tuple instead of a list and doctests have been updated appropriately.
📝 Checklist
⌛ Dependencies