Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
gh-39572: Change some instances of "gens" method to return tuples
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes #12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes #12345". --> Contributes to #34120 As noted in the referenced issue. most instances of the "gens" method return tuples, so the few instances of the method which return lists instead should be modified to return tuples. This pull request handles the following bullet points from the issue: - `SymmetricReductionStrategy` in `src/sage/rings/polynomial/symmetric_reduction.pyx` - `EllipticCurve_number_field` in `src/sage/schemes/elliptic_curves/ell_number_field.py` - `SpecialCubicQuotientRing` in `src/sage/schemes/hyperelliptic_curves/monsky_washnitzer.py` In each case the gens method from the mentioned class has been modified to return a tuple instead of a list and doctests have been updated appropriately. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [X] The title is concise and informative. - [X] The description explains in detail what this PR is about. - [X] I have linked a relevant issue or discussion. - [X] I have created tests covering the changes. - [X] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - #12345: short description why this is a dependency --> <!-- - #34567: ... --> URL: #39572 Reported by: Caleb Van't Land Reviewer(s): Vincent Macri
- Loading branch information