SALEOR-1888-1889 - Fix voucher and sales sorting errors (#1063)

* Fix voucher and sales sorting errors * Update changelog * Fix channel slug argument in sorting
saleor · Apr 19, 2021 · bddfa2c · bddfa2c
1 parent e5df1b2
commit bddfa2c
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -34,6 +34,7 @@ All notable, unreleased changes to this project will be documented in this file.
 - Handle limit reached error - #990 by @dominik-zeglen
 - Display Cloud limits - #1004 by @dominik-zeglen
 - Add shipping method description - #1058 by @jwm0
+- Fix voucher and sales sorting errors - #1063 by @orzechdev
 
 # 2.11.1
 

diff --git a/src/discounts/views/SaleList/SaleList.tsx b/src/discounts/views/SaleList/SaleList.tsx
@@ -75,7 +75,7 @@ export const SaleList: React.FC<SaleListProps> = ({ params }) => {
     () => ({
       ...paginationState,
       filter: getFilterVariables(params),
-      sort: getSortQueryVariables(params)
+      sort: getSortQueryVariables(params, channel?.slug)
     }),
     [params]
   );

diff --git a/src/discounts/views/VoucherList/VoucherList.tsx b/src/discounts/views/VoucherList/VoucherList.tsx
@@ -76,7 +76,7 @@ export const VoucherList: React.FC<VoucherListProps> = ({ params }) => {
     () => ({
       ...paginationState,
       filter: getFilterVariables(params),
-      sort: getSortQueryVariables(params)
+      sort: getSortQueryVariables(params, channel?.slug)
     }),
     [params]
   );

diff --git a/src/utils/sort.ts b/src/utils/sort.ts
@@ -72,21 +72,22 @@ type GetSortQueryField<TUrlField extends string, TSortField extends string> = (
 type GetSortQueryVariables<
   TSortField extends string,
   TParams extends Record<any, any>
-> = (params: TParams) => SortingInput<TSortField>;
+> = (params: TParams, channelSlug?: string) => SortingInput<TSortField>;
 export function createGetSortQueryVariables<
   TUrlField extends string,
   TSortField extends string,
   TParams extends Record<any, any>
 >(
   getSortQueryField: GetSortQueryField<TUrlField, TSortField>
 ): GetSortQueryVariables<TSortField, TParams> {
-  return (params: TParams) => {
+  return (params: TParams, channelSlug?: string) => {
     const field = getSortQueryField(params.sort);
 
     if (!!field) {
       return {
         direction: getOrderDirection(params.asc),
-        field
+        field,
+        channel: channelSlug
       };
     }