Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SALEOR-1888-1889 - Fix voucher and sales sorting errors #1063

Merged
merged 3 commits into from
Apr 19, 2021
Merged

SALEOR-1888-1889 - Fix voucher and sales sorting errors #1063

merged 3 commits into from
Apr 19, 2021

Conversation

orzechdev
Copy link
Contributor

@orzechdev orzechdev commented Apr 15, 2021 •
edited
Loading

I want to merge this change because... it fixes vouchers and sales sorting errors.

PR intended to be tested with API branch: master

Screenshots

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes [data-test-id] are added for new elements
  4. Changes are mentioned in the changelog
  5. The changes are tested in different browsers and in light/dark mode

Test environment config

API_URI=https://qa.staging.saleor.cloud/graphql/

@patrys
Copy link
Member

patrys commented Apr 15, 2021

Task linked: SALEOR-1888 [BUG][SALES] Sorting shows error

@github-actions github-actions bot temporarily deployed to saleor-1888-1889-fix-vouchers-sales-sorting-errors April 15, 2021 15:04 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-1888-1889-fix-vouchers-sales-sorting-errors April 15, 2021 15:04 Inactive
@patrys
Copy link
Member

patrys commented Apr 15, 2021

Task linked: SALEOR-1889 [BUG][VOUCHERS] Sorting shows error

@github-actions github-actions bot temporarily deployed to saleor-1888-1889-fix-vouchers-sales-sorting-errors April 15, 2021 15:07 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-1888-1889-fix-vouchers-sales-sorting-errors April 15, 2021 15:07 Inactive
@orzechdev orzechdev marked this pull request as ready for review April 16, 2021 09:54
@orzechdev orzechdev requested review from a team, dominik-zeglen and bmigirl and removed request for a team April 16, 2021 09:55
@eCzerniak eCzerniak self-requested a review April 19, 2021 07:33
@orzechdev orzechdev force-pushed the SALEOR-1888-1889-fix-vouchers-sales-sorting-errors branch from de07a81 to f5a8fd5 Compare April 19, 2021 10:06
@github-actions github-actions bot temporarily deployed to saleor-1888-1889-fix-vouchers-sales-sorting-errors April 19, 2021 10:07 Inactive
@github-actions github-actions bot temporarily deployed to storybook saleor-1888-1889-fix-vouchers-sales-sorting-errors April 19, 2021 10:07 Inactive
@github-actions github-actions bot temporarily deployed to saleor-1888-1889-fix-vouchers-sales-sorting-errors April 19, 2021 13:33 Inactive
@orzechdev orzechdev merged commit bddfa2c into master Apr 19, 2021
@orzechdev orzechdev deleted the SALEOR-1888-1889-fix-vouchers-sales-sorting-errors branch April 19, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eCzerniak eCzerniak eCzerniak approved these changes

@bmigirl bmigirl bmigirl approved these changes

@dominik-zeglen dominik-zeglen dominik-zeglen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@orzechdev @patrys @dominik-zeglen @bmigirl @eCzerniak