Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

horizontal scroll fix #1306

Merged
merged 2 commits into from
Aug 20, 2021
Merged

horizontal scroll fix #1306

merged 2 commits into from
Aug 20, 2021

Conversation

SektorDV
Copy link
Contributor

I want to merge this change because it fixes the issue with overflows being hidden in responsive tables.

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes [data-test-id] are added for new elements
  4. Changes are mentioned in the changelog
  5. The changes are tested in different browsers and in light/dark mode

Test environment config

API_URI=https://master.staging.saleor.cloud/graphql/

@patrys
Copy link
Member

patrys commented Aug 19, 2021

Task linked: SALEOR-4129 Add validation to not allow creating gift card with 0 balance amount

@github-actions github-actions bot temporarily deployed to saleor-4129-horizontal-scroll-fix August 19, 2021 10:42 Inactive
@SektorDV SektorDV requested a review from eCzerniak August 19, 2021 10:42
@github-actions github-actions bot had a problem deploying to storybook saleor-4129-horizontal-scroll-fix August 19, 2021 10:42 Failure
@SektorDV SektorDV requested review from a team, orzechdev and jwm0 and removed request for a team August 19, 2021 10:42
@SektorDV SektorDV added the 3.0 Related to Saleor 3.0 label Aug 19, 2021
jwm0
jwm0 suggested changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@jwm0 jwm0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're using lockfileVrsion 2 (npm v7) which generates a huge package-lock diff. Also, please rebase to newest 3.0 and make sure all jobs in CI pass

@github-actions github-actions bot temporarily deployed to saleor-4129-horizontal-scroll-fix August 20, 2021 10:39 Inactive
@patrys
Copy link
Member

patrys commented Aug 20, 2021

Task linked: SALEOR-4219 Tables do not support horizontal scroll

@jwm0 jwm0 merged commit 2a0739e into 3.0 Aug 20, 2021
@jwm0 jwm0 deleted the SALEOR-4129-horizontal-scroll-fix branch August 20, 2021 11:18
SektorDV added a commit that referenced this pull request Aug 20, 2021
@SektorDV
Horizontal scroll fix on tables (#1306)
6c8c552 
* restore horizontal overflows to responsive tables

* regenerate package-lock
jwm0 pushed a commit that referenced this pull request Aug 20, 2021
@SektorDV
Horizontal scroll fix on tables (#1306) (#1313)
a94a611 
* restore horizontal overflows to responsive tables

* regenerate package-lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwm0 jwm0 jwm0 approved these changes

@orzechdev orzechdev orzechdev approved these changes

@eCzerniak eCzerniak Awaiting requested review from eCzerniak

Assignees
No one assigned
Labels
3.0 Related to Saleor 3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SektorDV @patrys @orzechdev @jwm0