Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Horizontal scroll fix on tables #1313

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Horizontal scroll fix on tables #1313

merged 1 commit into from
Aug 20, 2021

Conversation

SektorDV
Copy link
Contributor

I want to merge this change because it resolves the issue of hidden overflows in responsive tables.

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes [data-test-id] are added for new elements
  4. Changes are mentioned in the changelog
  5. The changes are tested in different browsers and in light/dark mode

Test environment config

API_URI=https://master.staging.saleor.cloud/graphql/

@SektorDV
Horizontal scroll fix on tables (#1306)
6c8c552 
* restore horizontal overflows to responsive tables

* regenerate package-lock
@patrys
Copy link
Member

patrys commented Aug 20, 2021

Task linked: SALEOR-4129 Add validation to not allow creating gift card with 0 balance amount

@github-actions github-actions bot temporarily deployed to saleor-4129-horizontal-scroll-fix-3-1 August 20, 2021 12:02 Inactive
@jwm0 jwm0 merged commit a94a611 into master Aug 20, 2021
@jwm0 jwm0 deleted the SALEOR-4129-horizontal-scroll-fix-3.1 branch August 20, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SektorDV @patrys @jwm0