🎀 Increase global single test timeout 🎀 #5236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0a83dd0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
michalina-graczyk
changed the title
michalina-graczyk
changed the title
Cloud11PL
reviewed
Nov 5, 2024
| @@ -36,7 +36,7 @@ export default defineConfig({ | |||
| : [["html"], ["list"]], | |||
| expect: { timeout: 10 * 1000 }, | |||
| maxFailures: 10, | |||
| timeout: 30 * 1000, | |||
| timeout: 35 * 1000, | |||
There was a problem hiding this comment.
Suggestion: I think we should break down "long" tests into smaller tests if that's possible.
There was a problem hiding this comment.
Totally agree, let's first stabilize them and then refactor the 'long' one. This test locally tooks 17s
Cloud11PL
approved these changes
Nov 5, 2024
andrzejewsky
approved these changes
Nov 6, 2024
szczecha
approved these changes
Nov 6, 2024
Cloud11PL
pushed a commit
that referenced
this pull request
Nov 7, 2024
* Increase global single test timeout * add changeset
michalina-graczyk
added a commit
that referenced
this pull request
Nov 14, 2024
* Increase global single test timeout * add changeset
michalina-graczyk
added a commit
that referenced
this pull request
Nov 14, 2024
* Increase global single test timeout * add changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test passed locally and actually on CI too, the only error message was Test timeout of 30000ms exceeded. It may mean that 30s per test might be too short, so I increase them
What type of PR is this?
Related Issues or Documents
Usage Instructions, Screenshots, Recordings
Have you written tests?
[Optional] Description