Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎀 Increase global single test timeout 🎀 #5236

Merged
merged 2 commits into from
Nov 6, 2024
Merged

🎀 Increase global single test timeout 🎀 #5236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30ec4eb
Increase global single test timeout
michalina-graczyk Nov 5, 2024
0a83dd0
add changeset
michalina-graczyk Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cuddly-spiders-wave.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"saleor-dashboard": patch
---

Increase global single test timeout to avoid false neagtive test results
2 changes: 1 addition & 1 deletion playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export default defineConfig({
: [["html"], ["list"]],
expect: { timeout: 10 * 1000 },
maxFailures: 10,
timeout: 30 * 1000,
timeout: 35 * 1000,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: I think we should break down "long" tests into smaller tests if that's possible.

Copy link
Member Author

@michalina-graczyk michalina-graczyk Nov 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree, let's first stabilize them and then refactor the 'long' one. This test locally tooks 17s

use: {
baseURL: env.BASE_URL || "",
trace: env.CI ? "retain-on-failure" : "on",
Expand Down
Loading