Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/order reissue #910

Merged
merged 118 commits into from
Jan 20, 2021
Merged

Feature/order reissue #910

merged 118 commits into from
Jan 20, 2021

Conversation

bmigirl
Copy link
Contributor

@bmigirl bmigirl commented Dec 16, 2020

This pr is for QA purposed only for now. DO NOT MERGE

PR intended to be tested with API branch:

Screenshots

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Data-test are added for new elements.
  7. Type definitions are up to date.
  8. Changes are mentioned in the changelog.

Test environment config

API_URI=https://feature-possibility-to-return-products.api.saleor.rocks/graphql/

@github-actions github-actions bot temporarily deployed to feature-order-reissue January 19, 2021 09:26 Inactive
@github-actions github-actions bot temporarily deployed to storybook feature-order-reissue January 19, 2021 09:26 Inactive
@github-actions github-actions bot temporarily deployed to feature-order-reissue January 19, 2021 11:49 Inactive
@github-actions github-actions bot temporarily deployed to storybook feature-order-reissue January 19, 2021 11:49 Inactive
@github-actions github-actions bot temporarily deployed to feature-order-reissue January 20, 2021 11:11 Inactive
@github-actions github-actions bot temporarily deployed to storybook feature-order-reissue January 20, 2021 11:11 Inactive
Copy link

@mlamperski mlamperski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA tests finished. No issues found.


const messages = defineMessages({
fulfilled: {
defaultMessage: "Fulfilled from: ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translation strings shouldn't contain whitespaces at the beginning/end - let's fix that in the refactor afterwards

description: "fulfillment group"
},
restocked: {
defaultMessage: "Restocked from: ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@jwm0 jwm0 merged commit f0f9fe9 into master Jan 20, 2021
@jwm0 jwm0 deleted the feature/order-reissue branch January 20, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants