-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Field level tooltip to Combobox / Deprecate Input assistiveText.fieldLevelHelpButton #1689
Add Field level tooltip to Combobox / Deprecate Input assistiveText.fieldLevelHelpButton #1689
Conversation
Hi @interactivellama , what is the latest status on this PR? Any plan to merge this in? Thanks. Please let me know if any work is required before this PR can be submitted. |
@hajiz No, it's just been the Christmas/New Year holiday delay. I took a quick glance. I think I can merge this into master tomorrow. |
…to fieldLevelTooltipToCombobox
3caa41f
to
b65ce35
Compare
b65ce35
to
d0cf6b0
Compare
d0cf6b0
to
3408a1e
Compare
3408a1e
to
f2a8964
Compare
* Deprecate Input’s `assistiveText.fieldLevelHelpButton` prop and add a checkProp warning to use fieldLevelHelpTooltip. * Centralizes the default Tooltip props into it’s own module, so that code can be re-used across Combobox and Input. * Combobox/Tooltip: Use learnMore variant and remove custom Button/children props * Documents triggerStyle: { position: 'static' } usage and removes overflowBoundaryElement from example * Remove default for Input’s assistiveText.fieldLevelHelpButton so that Tooltip has the default “Help” text and not the Input component. Having defaults in two locations causing problems when merging objects. * Adds removeUndefined helper function
f2a8964
to
06880c2
Compare
@hajiz It is now merged. Would you like a release next week? |
Hi @interactivellama , thanks for merging the PR. We would ultimately love to have a release, but please let me figure out some dependencies and will get back to you shortly. |
Fixes #1681
Additional description
Work by @interactivellama
assistiveText.fieldLevelHelpButton
prop and add a checkProp warning to usefieldLevelHelpTooltip
'sassistiveText.triggerLearnMoreIcon
.learnMore
variantButton
component in order to make the info icon slightly smaller due to the removal of aspan
tag that wraps<Button><Icon/></Button
but not ifButton
's icon props are used.Console warning
CONTRIBUTOR checklist (do not remove)
Please complete for every pull request
npm run lint:fix
has been run and linting passes.components/component-docs.json
CI tests pass (npm test
).REVIEWER checklist (do not remove)
components/component-docs.json
tests.Required only if there are markup / UX changes
last-slds-markup-review
inpackage.json
and push.last-accessibility-review
, topackage.json
and push.npm run local-update
within locally cloned site repo to confirm the site will function correctly at the next release.