Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Field level tooltip to Combobox / Deprecate Input assistiveText.fieldLevelHelpButton #1689

Merged

Commits on Dec 13, 2018

  1. add inlineHelpTooltip

    David Ly-Gagnon committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    4b3e940 View commit details
    Browse the repository at this point in the history
  2. add fieldLevelHelpTooltip

    David Ly-Gagnon committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    bfe242f View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2018

  1. fix id

    David Ly-Gagnon committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    6989afb View commit details
    Browse the repository at this point in the history
  2. update snapshot

    David Ly-Gagnon committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    dcdb2fc View commit details
    Browse the repository at this point in the history
  3. update docs

    David Ly-Gagnon committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    167c2df View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2019

  1. Merge branch 'master' of github.com:salesforce/design-system-react in…

    …to fieldLevelTooltipToCombobox
    interactivellama committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    1913d8f View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2019

  1. Deprecate Input assistiveText.fieldLevelHelpButton

    * Deprecate Input’s `assistiveText.fieldLevelHelpButton` prop and add a checkProp warning to use fieldLevelHelpTooltip.
    * Centralizes the default Tooltip props into it’s own module, so that code can be re-used across Combobox and Input.
    * Combobox/Tooltip: Use learnMore variant and remove custom Button/children props
    * Documents triggerStyle: { position: 'static' } usage and removes overflowBoundaryElement from example
    * Remove default for Input’s assistiveText.fieldLevelHelpButton so that Tooltip has the default “Help” text and not the Input component. Having defaults in two locations causing problems when merging objects.
    * Adds removeUndefined helper function
    interactivellama committed Jan 5, 2019
    Configuration menu
    Copy the full SHA
    06880c2 View commit details
    Browse the repository at this point in the history