Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

failure in PR title validation must block merging a pull request #34

Closed
apapko opened this issue Jan 24, 2018 · 6 comments
Closed

failure in PR title validation must block merging a pull request #34

apapko opened this issue Jan 24, 2018 · 6 comments
Assignees
@diervo
Labels
enhancement

Comments

@apapko
Copy link
Collaborator

apapko commented Jan 24, 2018

Description

Error produced by ci/conventional-title validator does not disable pull request 'squash and merge' button. If title is invalid user should not be to merge pull request.
Configure git PR to disabled 'squash and merge' when title validation fails.

Applicable to lwc and best repos
@apapko apapko mentioned this issue Feb 2, 2018
Closed
@pmdartus
Copy link
Member

pmdartus commented Feb 14, 2018 •
edited
Loading

Github has the capability to block a branch merge if all the checks one of the checks is not a success. Before enabling this we need to stabilize the integration tests #95.

@caridy
Copy link
Contributor

caridy commented Feb 27, 2018

@apapko this can be closed now right?

@apapko
Copy link
Collaborator Author

apapko commented Feb 27, 2018 •
edited
Loading

@caridy, with semantic commit validation now enabled, we technically shouldn't be able to commit any invalid messages; however, to be bullet proof we should disable 'Squash and Merge' button if any of the PR checks fail.

@caridy
Copy link
Contributor

caridy commented Feb 28, 2018

No, I'm not ok with that!

@apapko
Copy link
Collaborator Author

apapko commented Feb 28, 2018

@caridy if allowing merges with failed checks is allowed then we can close this issue.

@apapko
Copy link
Collaborator Author

apapko commented Feb 28, 2018 •
edited
Loading

Closing in lieu of commit message validation work : #78

@apapko apapko closed this as completed Feb 28, 2018
pmdartus pushed a commit that referenced this issue Nov 12, 2024
@ravijayaramappa @apapko
feat: RFC for canonical metadata shape of LWC modules (#33)
5d62b78 
* feat: RFC for canonical metadata shape of LWC modules

* fix: table of content

* fix: minor polishing

* feat: add more types

* fix: address PR comments

rename file to follow convention for draft stage RFCs

* fix: define shape in typescript

* fix: incorporate feedback to treat modules as individual entry

* fix: update examples link for html template

* feat: support expressions

* feat: Update types for script and add link to samples

* docs(metadat): bundle metadata shape #2 @W-7263561@ (#34)

* docs(metadat): bundle metadata shape #2

* wip: add documentation

* wip: second pass

* wip: review comments

* wip: correct types

* docs: incorporate feedback about class members, imports, exports

* docs: incorporate feedback from PR comments

* docs: incorporate more feedback from review

* docs: add apis for each file type

* docs: add types for exisitng data binding ast for template

* docs: css custom property type (#37)

* docs: css custom property type

* docs: css custom property type

* wip: split refs and decls

* docs: update status to DRAFTED

* fix: minor improvements

* chore: 230 release updates

* docs: rename of project and call out design decisions

Co-authored-by: Aliaksandr Papko <apapko@salesforce.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diervo diervo

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@caridy @diervo @pmdartus @apapko