feat(compat): Moving push, unshift and concat to xproxy prototype #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Unfortunately we can't verify if the committer, David Turissini, has signed the CLA because they have not associated their commits with their GitHub user. Please follow these instructions to associate your commits with your GitHub user. Then sign the Salesforce Contributor License Agreement and this Pull Request will be revalidated. |
davidturissini
changed the title
|
@davidturissini please format PR title |
davidturissini
changed the title
|
@davidturissini don't mean to bother, but can we pls keep scope lower cased? Seems like convention for type and scope is always lowercase |
davidturissini
changed the title
ravijayaramappa
added a commit
that referenced
this pull request
Sep 11, 2019
@lwc/node-reactions Library to react to dom elements connecting and disconnecting from the document
pmdartus
pushed a commit
that referenced
this pull request
Nov 12, 2024
* feat: RFC for canonical metadata shape of LWC modules * fix: table of content * fix: minor polishing * feat: add more types * fix: address PR comments rename file to follow convention for draft stage RFCs * fix: define shape in typescript * fix: incorporate feedback to treat modules as individual entry * fix: update examples link for html template * feat: support expressions * feat: Update types for script and add link to samples * docs(metadat): bundle metadata shape #2 @W-7263561@ (#34) * docs(metadat): bundle metadata shape #2 * wip: add documentation * wip: second pass * wip: review comments * wip: correct types * docs: incorporate feedback about class members, imports, exports * docs: incorporate feedback from PR comments * docs: incorporate more feedback from review * docs: add apis for each file type * docs: add types for exisitng data binding ast for template * docs: css custom property type (#37) * docs: css custom property type * docs: css custom property type * wip: split refs and decls * docs: update status to DRAFTED * fix: minor improvements * chore: 230 release updates * docs: rename of project and call out design decisions Co-authored-by: Aliaksandr Papko <apapko@salesforce.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What kind of change does this PR introduce? (add 'x' - [x])
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
Please check if your PR fulfills the following requirements:
The PR fulfills these requirements:
commit-type(optional scope): commit description.http://conventionalcommits.org/
Other information:
Removes: Proxy.compatPush, Proxy.compatConcat, Proxy.compatUnshift in favor of push, concat and unshift defined on XProxy prototype.
This change will allow us to transpile less code especially when it comes to arrays.