refactor(engine): implementation of wired reform #1417
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caridy
commented
Jul 17, 2019
| cmpSlots: SlotSet; | ||
| cmpTrack: any; | ||
| cmpFields: Record<string, any>; |
There was a problem hiding this comment.
this is just a rename since the cmpTrack was exclusively a hash table for tracked fields, but in general, since they do not overlap, we can just generalize that for all important fields.
caridy
commented
Jul 17, 2019
| @@ -32,7 +35,7 @@ function wireDecorator( | |||
| ); | |||
| } | |||
| } | |||
| return createTrackedPropertyDescriptor( | |||
| return createWiredPropertyDescriptor( | |||
There was a problem hiding this comment.
instead of using the tracked field for wired fields, we now have a different implementation.
caridy
commented
Jul 17, 2019
| ); | ||
| } | ||
| // making the wired value as readonly | ||
| newValue = reactiveMembrane.getReadOnlyProxy(newValue); |
There was a problem hiding this comment.
@davidturissini this is the meat of it. Track uses reactiveMembrane.getProxy while this is now using reactiveMembrane.getReadOnlyProxy
Benchmark resultsBase commit: lwc-engine-benchmark
|
|
@caridy it sounds like there's a doc impact. Can you please explain this change with before and after code samples? Thanks in advance. |
|
yes,. @jbleyleSF @pmdartus this is mostly experimental, to see where we land. |
caridy
changed the title
This was referenced Aug 12, 2019
|
Closed in favor of #1459 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EXPERIMENTAL_REFACTOR
Details
First refactor to slowly iron out the way a wire adapter sets values into a wired fields. In this first step, we transform the behavior of the value set into a field from a reactive proxy to a readonly proxy.
Does this PR introduce breaking changes?
Yes, it does introduce breaking changes.If yes, please describe the impact and migration path for existing applications.
The potential impact here is for someone wiring to a field, and making manual mutations to the value that was wired. The workaround is to split out that logic into a tracked value, while keeping the wired field as set by the adapter.
The PR fulfills these requirements: