test: test slots not at top level #4689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Oct 24, 2024
wjhsf
approved these changes
Oct 24, 2024
ekashida
approved these changes
Oct 24, 2024
nolanlawson
commented
Oct 24, 2024
| @@ -21,7 +21,7 @@ exports.STANDARD_SAUCE_BROWSERS = [ | |||
| label: 'sl_safari_latest', | |||
| browserName: 'safari', | |||
| browserVersion: 'latest', | |||
| platformName: 'macOS 12', // Note: this must be updated when macOS releases new updates | |||
| platformName: 'macOS 13', // Note: this must be updated when macOS releases new updates | |||
There was a problem hiding this comment.
Safari 16 doesn't implement Document.parseHTMLUnsafe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
When working on the SSR compiler, the question came up of how
slotattributes work when not at the top level, e.g.:The answer seems to be that our behavior for light DOM slots is correct insofar as it matches native shadow DOM behavior (which is that only
slotattributes at the true top level – just elements, not including our framework directives like<template lwc:if>). Synthetic shadow also seems to behave correctly.This PR is just asserting the existing behavior.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?