Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test slots not at top level #4689

Merged
merged 8 commits into from
Oct 24, 2024
Merged

test: test slots not at top level #4689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2cb98e3
test: test slots not at top level
nolanlawson Oct 24, 2024
856dd5d
Update packages/@lwc/integration-karma/helpers/test-utils.js
nolanlawson Oct 24, 2024
4e8144d
fix: traverse shadow roots
nolanlawson Oct 24, 2024
11942f8
fix: try to fix old safari
nolanlawson Oct 24, 2024
598ca56
chore: update safari version
nolanlawson Oct 24, 2024
662e97e
test: skip test in older browsers
nolanlawson Oct 24, 2024
5efdfd1
chore: fix old api versions
nolanlawson Oct 24, 2024
032ff0f
fix: fix api versions
nolanlawson Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added ...s/@lwc/engine-server/src/__tests__/fixtures/slot-not-at-top-level/element/light/error.txt
View file
Open in desktop
Empty file.
22 changes: 22 additions & 0 deletions ...wc/engine-server/src/__tests__/fixtures/slot-not-at-top-level/element/light/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<x-outer>
<x-inner>
a
<!---->
<div>
<div slot="foo">
I am the foo slot
</div>
</div>
<div>
<div slot="foo">
I am also the foo slot
</div>
</div>
<!---->
b
<!---->
fallback for foo
<!---->
c
</x-inner>
</x-outer>
3 changes: 3 additions & 0 deletions ...es/@lwc/engine-server/src/__tests__/fixtures/slot-not-at-top-level/element/light/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export const tagName = 'x-outer';
export { default } from 'x/outer';
export * from 'x/outer';
7 changes: 7 additions & 0 deletions ...ver/src/__tests__/fixtures/slot-not-at-top-level/element/light/modules/x/inner/inner.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<template lwc:render-mode="light">
a
<slot>fallback for default</slot>
b
<slot name=foo>fallback for foo</slot>
c
</template>
5 changes: 5 additions & 0 deletions ...erver/src/__tests__/fixtures/slot-not-at-top-level/element/light/modules/x/inner/inner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import { LightningElement} from 'lwc';

export default class extends LightningElement {
static renderMode = 'light'
}
10 changes: 10 additions & 0 deletions ...ver/src/__tests__/fixtures/slot-not-at-top-level/element/light/modules/x/outer/outer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<template lwc:render-mode="light">
<x-inner>
<div>
<div slot="foo">I am the foo slot</div>
</div>
<div>
<div slot="foo">I am also the foo slot</div>
</div>
</x-inner>
</template>
5 changes: 5 additions & 0 deletions ...erver/src/__tests__/fixtures/slot-not-at-top-level/element/light/modules/x/outer/outer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import { LightningElement} from 'lwc';

export default class extends LightningElement {
static renderMode = 'light'
}
Empty file added .../@lwc/engine-server/src/__tests__/fixtures/slot-not-at-top-level/element/shadow/error.txt
View file
Open in desktop
Empty file.
27 changes: 27 additions & 0 deletions ...c/engine-server/src/__tests__/fixtures/slot-not-at-top-level/element/shadow/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
<x-outer>
<template shadowrootmode="open">
<x-inner>
<template shadowrootmode="open">
a
<slot>
fallback for default
</slot>
b
<slot name="foo">
fallback for foo
</slot>
c
</template>
<div>
<div slot="foo">
I am the foo slot
</div>
</div>
<div>
<div slot="foo">
I am also the foo slot
</div>
</div>
</x-inner>
</template>
</x-outer>
3 changes: 3 additions & 0 deletions ...s/@lwc/engine-server/src/__tests__/fixtures/slot-not-at-top-level/element/shadow/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export const tagName = 'x-outer';
export { default } from 'x/outer';
export * from 'x/outer';
7 changes: 7 additions & 0 deletions ...er/src/__tests__/fixtures/slot-not-at-top-level/element/shadow/modules/x/inner/inner.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<template>
a
<slot>fallback for default</slot>
b
<slot name=foo>fallback for foo</slot>
c
</template>
4 changes: 4 additions & 0 deletions ...rver/src/__tests__/fixtures/slot-not-at-top-level/element/shadow/modules/x/inner/inner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import { LightningElement} from 'lwc';

export default class extends LightningElement {
}
10 changes: 10 additions & 0 deletions ...er/src/__tests__/fixtures/slot-not-at-top-level/element/shadow/modules/x/outer/outer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<template>
<x-inner>
<div>
<div slot="foo">I am the foo slot</div>
</div>
<div>
<div slot="foo">I am also the foo slot</div>
</div>
</x-inner>
</template>
4 changes: 4 additions & 0 deletions ...rver/src/__tests__/fixtures/slot-not-at-top-level/element/shadow/modules/x/outer/outer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import { LightningElement} from 'lwc';

export default class extends LightningElement {
}
Empty file added .../@lwc/engine-server/src/__tests__/fixtures/slot-not-at-top-level/external/light/error.txt
View file
Open in desktop
Empty file.
22 changes: 22 additions & 0 deletions ...c/engine-server/src/__tests__/fixtures/slot-not-at-top-level/external/light/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<x-outer>
<x-inner>
a
<!---->
<x-external>
<div slot="foo">
I am the foo slot
</div>
</x-external>
<x-external>
<div slot="foo">
I am also the foo slot
</div>
</x-external>
<!---->
b
<!---->
fallback for foo
<!---->
c
</x-inner>
</x-outer>
3 changes: 3 additions & 0 deletions ...s/@lwc/engine-server/src/__tests__/fixtures/slot-not-at-top-level/external/light/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export const tagName = 'x-outer';
export { default } from 'x/outer';
export * from 'x/outer';
7 changes: 7 additions & 0 deletions ...er/src/__tests__/fixtures/slot-not-at-top-level/external/light/modules/x/inner/inner.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<template lwc:render-mode="light">
a
<slot>fallback for default</slot>
b
<slot name=foo>fallback for foo</slot>
c
</template>
5 changes: 5 additions & 0 deletions ...rver/src/__tests__/fixtures/slot-not-at-top-level/external/light/modules/x/inner/inner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import { LightningElement} from 'lwc';

export default class extends LightningElement {
static renderMode = 'light'
}
10 changes: 10 additions & 0 deletions ...er/src/__tests__/fixtures/slot-not-at-top-level/external/light/modules/x/outer/outer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<template lwc:render-mode="light">
<x-inner>
<x-external lwc:external>
<div slot="foo">I am the foo slot</div>
</x-external>
<x-external lwc:external>
<div slot="foo">I am also the foo slot</div>
</x-external>
</x-inner>
</template>
5 changes: 5 additions & 0 deletions ...rver/src/__tests__/fixtures/slot-not-at-top-level/external/light/modules/x/outer/outer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import { LightningElement} from 'lwc';

export default class extends LightningElement {
static renderMode = 'light'
}
Empty file added ...@lwc/engine-server/src/__tests__/fixtures/slot-not-at-top-level/external/shadow/error.txt
View file
Open in desktop
Empty file.
27 changes: 27 additions & 0 deletions .../engine-server/src/__tests__/fixtures/slot-not-at-top-level/external/shadow/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
<x-outer>
<template shadowrootmode="open">
<x-inner>
<template shadowrootmode="open">
a
<slot>
fallback for default
</slot>
b
<slot name="foo">
fallback for foo
</slot>
c
</template>
<x-external>
<div slot="foo">
I am the foo slot
</div>
</x-external>
<x-external>
<div slot="foo">
I am also the foo slot
</div>
</x-external>
</x-inner>
</template>
</x-outer>
3 changes: 3 additions & 0 deletions .../@lwc/engine-server/src/__tests__/fixtures/slot-not-at-top-level/external/shadow/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export const tagName = 'x-outer';
export { default } from 'x/outer';
export * from 'x/outer';
7 changes: 7 additions & 0 deletions ...r/src/__tests__/fixtures/slot-not-at-top-level/external/shadow/modules/x/inner/inner.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<template>
a
<slot>fallback for default</slot>
b
<slot name=foo>fallback for foo</slot>
c
</template>
4 changes: 4 additions & 0 deletions ...ver/src/__tests__/fixtures/slot-not-at-top-level/external/shadow/modules/x/inner/inner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import { LightningElement} from 'lwc';

export default class extends LightningElement {
}
10 changes: 10 additions & 0 deletions ...r/src/__tests__/fixtures/slot-not-at-top-level/external/shadow/modules/x/outer/outer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<template>
<x-inner>
<x-external lwc:external>
<div slot="foo">I am the foo slot</div>
</x-external>
<x-external lwc:external>
<div slot="foo">I am also the foo slot</div>
</x-external>
</x-inner>
</template>
4 changes: 4 additions & 0 deletions ...ver/src/__tests__/fixtures/slot-not-at-top-level/external/shadow/modules/x/outer/outer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import { LightningElement} from 'lwc';

export default class extends LightningElement {
}
Empty file added ...es/@lwc/engine-server/src/__tests__/fixtures/slot-not-at-top-level/ifTrue/light/error.txt
View file
Open in desktop
Empty file.
18 changes: 18 additions & 0 deletions ...lwc/engine-server/src/__tests__/fixtures/slot-not-at-top-level/ifTrue/light/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<x-outer>
<x-inner>
a
<!---->
fallback for default
<!---->
b
<!---->
<div>
I am the foo slot
</div>
<div>
I am also the foo slot
</div>
<!---->
c
</x-inner>
</x-outer>
3 changes: 3 additions & 0 deletions ...ges/@lwc/engine-server/src/__tests__/fixtures/slot-not-at-top-level/ifTrue/light/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export const tagName = 'x-outer';
export { default } from 'x/outer';
export * from 'x/outer';
7 changes: 7 additions & 0 deletions ...rver/src/__tests__/fixtures/slot-not-at-top-level/ifTrue/light/modules/x/inner/inner.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<template lwc:render-mode="light">
a
<slot>fallback for default</slot>
b
<slot name=foo>fallback for foo</slot>
c
</template>
5 changes: 5 additions & 0 deletions ...server/src/__tests__/fixtures/slot-not-at-top-level/ifTrue/light/modules/x/inner/inner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import { LightningElement} from 'lwc';

export default class extends LightningElement {
static renderMode = 'light'
}
10 changes: 10 additions & 0 deletions ...rver/src/__tests__/fixtures/slot-not-at-top-level/ifTrue/light/modules/x/outer/outer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<template lwc:render-mode="light">
<x-inner>
<template if:true={isTrue}>
<div slot="foo">I am the foo slot</div>
</template>
<template if:true={isTrue}>
<div slot="foo">I am also the foo slot</div>
</template>
</x-inner>
</template>
6 changes: 6 additions & 0 deletions ...server/src/__tests__/fixtures/slot-not-at-top-level/ifTrue/light/modules/x/outer/outer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import { LightningElement} from 'lwc';

export default class extends LightningElement {
static renderMode = 'light'
isTrue = true
}
Empty file added ...s/@lwc/engine-server/src/__tests__/fixtures/slot-not-at-top-level/ifTrue/shadow/error.txt
View file
Open in desktop
Empty file.
23 changes: 23 additions & 0 deletions ...wc/engine-server/src/__tests__/fixtures/slot-not-at-top-level/ifTrue/shadow/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<x-outer>
<template shadowrootmode="open">
<x-inner>
<template shadowrootmode="open">
a
<slot>
fallback for default
</slot>
b
<slot name="foo">
fallback for foo
</slot>
c
</template>
<div slot="foo">
I am the foo slot
</div>
<div slot="foo">
I am also the foo slot
</div>
</x-inner>
</template>
</x-outer>
3 changes: 3 additions & 0 deletions ...es/@lwc/engine-server/src/__tests__/fixtures/slot-not-at-top-level/ifTrue/shadow/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export const tagName = 'x-outer';
export { default } from 'x/outer';
export * from 'x/outer';
7 changes: 7 additions & 0 deletions ...ver/src/__tests__/fixtures/slot-not-at-top-level/ifTrue/shadow/modules/x/inner/inner.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<template>
a
<slot>fallback for default</slot>
b
<slot name=foo>fallback for foo</slot>
c
</template>
4 changes: 4 additions & 0 deletions ...erver/src/__tests__/fixtures/slot-not-at-top-level/ifTrue/shadow/modules/x/inner/inner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import { LightningElement} from 'lwc';

export default class extends LightningElement {
}
10 changes: 10 additions & 0 deletions ...ver/src/__tests__/fixtures/slot-not-at-top-level/ifTrue/shadow/modules/x/outer/outer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<template>
<x-inner>
<template if:true={isTrue}>
<div slot="foo">I am the foo slot</div>
</template>
<template if:true={isTrue}>
<div slot="foo">I am also the foo slot</div>
</template>
</x-inner>
</template>
5 changes: 5 additions & 0 deletions ...erver/src/__tests__/fixtures/slot-not-at-top-level/ifTrue/shadow/modules/x/outer/outer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import { LightningElement} from 'lwc';

export default class extends LightningElement {
isTrue = true
}
Empty file added ...ges/@lwc/engine-server/src/__tests__/fixtures/slot-not-at-top-level/lwcIf/light/error.txt
View file
Open in desktop
Empty file.
18 changes: 18 additions & 0 deletions ...@lwc/engine-server/src/__tests__/fixtures/slot-not-at-top-level/lwcIf/light/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<x-outer>
<x-inner>
a
<!---->
fallback for default
<!---->
b
<!---->
<div>
I am the foo slot
</div>
<div>
I am also the foo slot
</div>
<!---->
c
</x-inner>
</x-outer>
3 changes: 3 additions & 0 deletions ...ages/@lwc/engine-server/src/__tests__/fixtures/slot-not-at-top-level/lwcIf/light/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export const tagName = 'x-outer';
export { default } from 'x/outer';
export * from 'x/outer';
7 changes: 7 additions & 0 deletions ...erver/src/__tests__/fixtures/slot-not-at-top-level/lwcIf/light/modules/x/inner/inner.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<template lwc:render-mode="light">
a
<slot>fallback for default</slot>
b
<slot name=foo>fallback for foo</slot>
c
</template>
5 changes: 5 additions & 0 deletions ...-server/src/__tests__/fixtures/slot-not-at-top-level/lwcIf/light/modules/x/inner/inner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import { LightningElement} from 'lwc';

export default class extends LightningElement {
static renderMode = 'light'
}
Loading
Loading