Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vscode extension name cannot be scoped #823

Merged
merged 2 commits into from
Mar 15, 2020
Merged

fix: vscode extension name cannot be scoped #823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
826e645
fix: vscode extension name cannot be scoped
Mar 15, 2020
b0e2b2d
fixed package name in CircleCI config
Mar 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ jobs:

- run:
name: Create a VSIX file
command: yarn workspace @salto-io/vscode package
command: yarn workspace salto-vscode package

- upload_pkg:
workspace_dir: vscode
Expand Down
2 changes: 1 addition & 1 deletion packages/vscode/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "@salto-io/vscode",
"name": "salto-vscode",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hadard notice that you commented on this the last time as well, it can't be under the org using the @ token since it borks up the extensions build script

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least I’m consist 😉

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least I’m consist 😉

"displayName": "Salto",
"description": "Configure Salto patches in vscode.",
"version": "0.1.11",
Expand Down
14 changes: 8 additions & 6 deletions packages/vscode/scripts/package.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
#!/bin/bash
set -xeuo pipefail

mkdir -p ./tmp_pkg && vsce package --yarn -o ./tmp_pkg/salto.vsix
cd ./tmp_pkg && unzip salto.vsix
cp -r ../node_modules/* extension/node_modules/
zip -ur salto.vsix extension
cd ./tmp_pkg && unzip salto.vsix
cp -r ../node_modules/* extension/node_modules/
zip -ur salto.vsix extension
cd ..
mkdir -p ./pkg
cp ./tmp_pkg/salto.vsix ./pkg/salto.vsix
rm -rf ./tmp_pkg
mkdir -p ./pkg
cp ./tmp_pkg/salto.vsix ./pkg/salto.vsix
rm -rf ./tmp_pkg