Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redhat): use correct location for config file #81

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

noelmcloughlin
Copy link
Member

@noelmcloughlin noelmcloughlin commented Jul 9, 2021

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

This PR fixes a bug - Set the correct location of configuration is /etc/rabbitmq/rabbitmq.conf on RedHat OS.

The RabbitMQ document states

"Users and deployment tool should use the following locations when creating the files:"

image

https://www.rabbitmq.com/configure.html#config-location

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@noelmcloughlin noelmcloughlin requested a review from myii July 9, 2021 00:24
@noelmcloughlin
Copy link
Member Author

noelmcloughlin commented Jul 9, 2021

It's not a breaking change because docs (https://www.rabbitmq.com/configure.html#config-location) says:

RabbitMQ packages or nodes will not create any configuration files.

So by default, the formula never generated rabbitmq.conf on RedHat (or any OS) before now, or somebody would have noticed the configuration file was corrupt: #80

@noelmcloughlin
Copy link
Member Author

selfie-merging as need to raise new PR to fix clustering

@noelmcloughlin noelmcloughlin merged commit bba0f3f into saltstack-formulas:master Jul 14, 2021
@saltstack-formulas-travis

🎉 This PR is included in version 1.1.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants