fix(tofs): use literal pillar (config) paths instead of tpldir
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* With nested `.sls` files, `tpldir` respectively resolves to: - `systemd/networkd` - `systemd/resolved` - `systemd/timesyncd` * Without this fix, only the default value provided is ever used, respectively: - `['network']` - `['resolved.conf']` - `['timesyncd.conf']`
myii
added a commit
to myii/template-formula
that referenced
this pull request
Feb 25, 2019
* With nested `.sls` files, `tpldir` respectively resolves to: - `template/<subdir>` * Without this fix, only the default value provided is ever used, respectively: - `['example.tmpl', 'example.tmpl.jinja']` * Follows-on from saltstack-formulas/systemd-formula#22
|
@aboe76 |
myii
added a commit
to myii/stack-formula
that referenced
this pull request
Feb 25, 2019
* With nested `.sls` files, `tpldir` respectively resolves to: - `stack/<subdir>` * Without this fix, only the default value provided is ever used, respectively: - `stack-config`: ['sdb.conf'] - `stack-keys-config`: ['sdb_keys.conf'] * Follows-on from: - saltstack-formulas/systemd-formula#22 - saltstack-formulas/template-formula#49
|
@myii you are right about this, but let's see if template-formula works, we have some more formula's with tofs pattern awaiting... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.slsfiles,tpldirrespectively resolves to:systemd/networkdsystemd/resolvedsystemd/timesyncd['network']['resolved.conf']['timesyncd.conf']@aboe76 In my defense, I did voice my concerns about #17 being merged too quickly without full testing. In any case, this isn't a substantial bug since all it prevents is the extra configurability which no-one is using right now.
I've gone for this simplest fix but I really am considering whether we should use
topdirin place oftpldirinstead. What's your take on that?