Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH DEBT] Migrate from invoke to tools #64374

Closed
s0undt3ch opened this issue May 27, 2023 · 0 comments · Fixed by #64376
Closed

[TECH DEBT] Migrate from invoke to tools #64374

s0undt3ch opened this issue May 27, 2023 · 0 comments · Fixed by #64376
Assignees

Comments

@s0undt3ch
Copy link
Collaborator

Previously we relied on invoke to run script some tasks.
With the adoption of GH Actions, invoke fell short and python-tools-scripts was created and is now what should be used.

Migrate all of the scripts in tasks/ to tools/

@s0undt3ch s0undt3ch self-assigned this May 27, 2023
@dwoz dwoz added this to the Sulfur v3006.2 milestone May 27, 2023
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue May 27, 2023
* `tasks/docs.py` -> `tools/precommit/docs.py`
* `tasks/docstrings.py` -> `tools/precommit/docstrings.py`

Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue May 27, 2023
Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue May 27, 2023
Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue May 27, 2023
Fixes saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch s0undt3ch linked a pull request May 27, 2023 that will close this issue
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue May 27, 2023
* `tasks/docs.py` -> `tools/precommit/docs.py`
* `tasks/docstrings.py` -> `tools/precommit/docstrings.py`

Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue May 27, 2023
Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue May 27, 2023
Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue May 27, 2023
Fixes saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue May 28, 2023
* `tasks/docs.py` -> `tools/precommit/docs.py`
* `tasks/docstrings.py` -> `tools/precommit/docstrings.py`

Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue May 28, 2023
Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue May 28, 2023
Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue May 28, 2023
Fixes saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue May 29, 2023
* `tasks/docs.py` -> `tools/precommit/docs.py`
* `tasks/docstrings.py` -> `tools/precommit/docstrings.py`

Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue May 29, 2023
Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue May 29, 2023
Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue May 29, 2023
Fixes saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue May 29, 2023
* `tasks/docs.py` -> `tools/precommit/docs.py`
* `tasks/docstrings.py` -> `tools/precommit/docstrings.py`

Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue May 29, 2023
Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue May 29, 2023
Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue May 29, 2023
Fixes saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue May 29, 2023
* `tasks/docs.py` -> `tools/precommit/docs.py`
* `tasks/docstrings.py` -> `tools/precommit/docstrings.py`

Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue May 29, 2023
Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue May 29, 2023
Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue May 29, 2023
Fixes saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue May 29, 2023
* `tasks/docs.py` -> `tools/precommit/docs.py`
* `tasks/docstrings.py` -> `tools/precommit/docstrings.py`

Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Nov 17, 2023
* `tasks/docs.py` -> `tools/precommit/docs.py`
* `tasks/docstrings.py` -> `tools/precommit/docstrings.py`

Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Nov 17, 2023
Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Nov 17, 2023
Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Nov 17, 2023
Fixes saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Nov 17, 2023
* `tasks/docs.py` -> `tools/precommit/docs.py`
* `tasks/docstrings.py` -> `tools/precommit/docstrings.py`

Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Nov 17, 2023
Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Nov 17, 2023
Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Nov 17, 2023
Fixes saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Nov 18, 2023
Fixes saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Nov 19, 2023
* `tasks/docs.py` -> `tools/precommit/docs.py`
* `tasks/docstrings.py` -> `tools/precommit/docstrings.py`

Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Nov 19, 2023
Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Nov 19, 2023
Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Nov 19, 2023
Fixes saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Nov 20, 2023
* `tasks/docs.py` -> `tools/precommit/docs.py`
* `tasks/docstrings.py` -> `tools/precommit/docstrings.py`

Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Nov 20, 2023
Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Nov 20, 2023
Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Nov 20, 2023
Fixes saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Nov 21, 2023
* `tasks/docs.py` -> `tools/precommit/docs.py`
* `tasks/docstrings.py` -> `tools/precommit/docstrings.py`

Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Nov 21, 2023
Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Nov 21, 2023
Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Nov 21, 2023
Fixes saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Nov 22, 2023
* `tasks/docs.py` -> `tools/precommit/docs.py`
* `tasks/docstrings.py` -> `tools/precommit/docstrings.py`

Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Nov 22, 2023
Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Nov 22, 2023
Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Nov 22, 2023
Fixes saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit that referenced this issue Nov 23, 2023
* `tasks/docs.py` -> `tools/precommit/docs.py`
* `tasks/docstrings.py` -> `tools/precommit/docstrings.py`

Refs #64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit that referenced this issue Nov 23, 2023
Refs #64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
s0undt3ch added a commit that referenced this issue Nov 23, 2023
Refs #64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@dwoz dwoz closed this as completed in effd3da Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants