Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3006.x] Migrate from invoke to tools #64376

Merged
merged 16 commits into from
Nov 23, 2023
Merged

[3006.x] Migrate from invoke to tools #64376

merged 16 commits into from
Nov 23, 2023

Conversation

s0undt3ch
Copy link
Collaborator

What does this PR do?

See title

What issues does this PR fix or reference?

Fixes: #64374

@s0undt3ch s0undt3ch requested a review from a team as a code owner May 27, 2023 18:39
@s0undt3ch s0undt3ch requested review from garethgreenaway and removed request for a team May 27, 2023 18:39
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Migrate from invoke to tools [3006.x] Migrate from invoke to tools May 27, 2023
@s0undt3ch s0undt3ch linked an issue May 27, 2023 that may be closed by this pull request
[TECH DEBT] Migrate from invoke to tools #64374
Closed
@s0undt3ch s0undt3ch force-pushed the hotfix/invoke-2-tools branch 24 times, most recently from 2c1d1c7 to 03a3e6c Compare May 29, 2023 19:54
@s0undt3ch s0undt3ch temporarily deployed to ci May 29, 2023 20:11 — with GitHub Actions Inactive
@s0undt3ch
Update the tools requirements
a34d223 
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch
The setup-python-tools-scripts actions now takes care of all the ca…
e0f6bb5 
…ching

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch
Migrated some invoke tasks to python-tools-scripts
ee29f06 
* `tasks/docs.py` -> `tools/precommit/docs.py`
* `tasks/docstrings.py` -> `tools/precommit/docstrings.py`

Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch
Migrate tasks/loader.py -> tools/precommit/loader.py
02ec124 
Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch
Migrated tasks/filemap.py -> tools/precommit/filemap.py
ea77548 
Refs saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch
Removed all remaining invoke support
696f859 
Fixes saltstack#64374

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch
Echo the installed version
9a6eac0 
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch
Bump cache seed
8829d68 
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch
Colored pre-commit output
65e2fdc 
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch
Add Py3.11 requirements
470d120 
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch
Set TOOLS_VIRTUALENV_CACHE_SEED
21f9fe2 
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch
Install tools in a virtualenv
fe76268 
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch
Fix the python executable path for the cached-virtualenv action output
da448b2 
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch
Setup relenv after python-tools-scripts
4f25cde 
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch
Drop the cache-suffix from the setup-python-tools-scripts action
ed42d27 
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch s0undt3ch force-pushed the hotfix/invoke-2-tools branch from 5f94d64 to ed42d27 Compare November 22, 2023 17:32
@s0undt3ch s0undt3ch merged commit 234693b into saltstack:3006.x Nov 23, 2023
754 checks passed
@s0undt3ch s0undt3ch deleted the hotfix/invoke-2-tools branch November 23, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garethgreenaway garethgreenaway Awaiting requested review from garethgreenaway garethgreenaway was automatically assigned from saltstack/team-core

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TECH DEBT] Migrate from invoke to tools
1 participant
@s0undt3ch