Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3006.x] Preserve master credentials on spawning platforms #64944

Merged
merged 2 commits into from
Aug 15, 2023
Merged

[3006.x] Preserve master credentials on spawning platforms #64944

merged 2 commits into from
Aug 15, 2023

Conversation

dwoz
Copy link
Contributor

@dwoz dwoz commented Aug 9, 2023

What does this PR do?

Prevent spawning platform minions from having to re-authenticate on every job when using multiprocessing=True

What issues does this PR fix or reference?

Fixes: #64914

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

@dwoz dwoz requested a review from a team as a code owner August 9, 2023 05:00
@dwoz dwoz requested review from garethgreenaway and removed request for a team August 9, 2023 05:00
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Preserve master credentials on spawning platforms [master] Preserve master credentials on spawning platforms Aug 9, 2023
@dwoz dwoz changed the base branch from master to 3006.x August 9, 2023 05:01
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title [master] Preserve master credentials on spawning platforms [3006.x] Preserve master credentials on spawning platforms Aug 9, 2023
@dwoz dwoz temporarily deployed to ci August 9, 2023 05:17 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 9, 2023 05:17 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 9, 2023 05:17 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 9, 2023 05:18 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 9, 2023 05:33 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 9, 2023 05:38 — with GitHub Actions Inactive
@dwoz dwoz force-pushed the issue/3006.x/64914 branch 4 times, most recently from cdd434a to 0f41c9a Compare August 9, 2023 08:18
@dwoz dwoz temporarily deployed to ci August 9, 2023 14:38 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 9, 2023 14:38 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 9, 2023 14:38 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 9, 2023 14:38 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 9, 2023 14:57 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 9, 2023 15:00 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 9, 2023 18:54 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 9, 2023 18:54 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 9, 2023 18:54 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 9, 2023 18:54 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 9, 2023 18:54 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 9, 2023 18:54 — with GitHub Actions Inactive
Ch3LL
Ch3LL previously approved these changes Aug 9, 2023
View reviewed changes
@dwoz dwoz temporarily deployed to ci August 12, 2023 02:19 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 12, 2023 02:19 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 12, 2023 02:19 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 12, 2023 02:20 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 12, 2023 02:20 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 12, 2023 03:15 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 12, 2023 03:15 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 12, 2023 03:15 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 12, 2023 03:15 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 12, 2023 03:15 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 12, 2023 03:15 — with GitHub Actions Inactive
dwoz added 2 commits August 14, 2023 14:42
@dwoz
Preserve master credentials on spawning platforms
f86a2dc 
Prevent spawning platform minions from having to re-authenticate on
every job when using multiprocessing=True
@dwoz
Give tests a better chance of passing
d480505
@dwoz dwoz force-pushed the issue/3006.x/64914 branch from 2240ed6 to d480505 Compare August 14, 2023 21:43
@dwoz dwoz temporarily deployed to ci August 14, 2023 23:14 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 14, 2023 23:15 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 14, 2023 23:33 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 14, 2023 23:38 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 14, 2023 23:58 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 15, 2023 00:00 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 15, 2023 03:13 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 15, 2023 03:13 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 15, 2023 03:13 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 15, 2023 03:13 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 15, 2023 03:13 — with GitHub Actions Inactive
@dwoz dwoz temporarily deployed to ci August 15, 2023 03:13 — with GitHub Actions Inactive
@s0undt3ch s0undt3ch merged commit 20f9b6a into saltstack:3006.x Aug 15, 2023
@twangboy twangboy mentioned this pull request Aug 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s0undt3ch s0undt3ch s0undt3ch approved these changes

@Ch3LL Ch3LL Ch3LL left review comments

@garethgreenaway garethgreenaway Awaiting requested review from garethgreenaway garethgreenaway was automatically assigned from saltstack/team-core

Assignees
No one assigned
Labels
Sulfur v3006.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Windows re-authenticates on every job
3 participants
@dwoz @s0undt3ch @Ch3LL