-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3006.x] fixes #65340 correct use of egrep to parse semanage output #65341
Conversation
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will require test coverage and a changelog
@ndptech FYI for any PR to be accepted, it requires tests (written using pytest) and a changelog, these were requested a month ago. Are you still interested in continuing this PR ? A rebase against the latest 3006.x branch would not be amiss too |
@dmurphy18 I am still interested in continuing, but have been very busy. |
@ndptech Do you mind if I take your PR and run with it, making the changelog and tests for it, and have you review the changes, along with the core team. |
@dmurphy18 That's absolutely fine. |
@ndptech This PR is superseded by PR #65524, please review that PR at your leisure and consider closing this PR. |
What does this PR do?
What issues does this PR fix or reference?
Fixes: #65340
Commits signed with GPG?
Yes