[3006.x] Ensure quoted filespec when using egrep to allow for regex with selinux #65524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
|
This PR supersedes PR #65341 |
twangboy
previously approved these changes
Nov 9, 2023
s0undt3ch
suggested changes
Nov 9, 2023
twangboy
approved these changes
Nov 14, 2023
s0undt3ch
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ensure that a quoted named filespec is used when searching the output of 'semanage fcontext -l' with egrep so ensure that regex named values are interpreted correctly.
What issues does this PR fix or reference?
Fixes: #65340
Previous Behavior
Various regex names were confused with each other, preventing subsequent regex name values from being added.
New Behavior
Various regex names are no longer confused with each other, allowing subsequent regex name values to be added.
Remove this section if not relevant
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.