Skip to content

Conversation

@sam-goodwin
Copy link
Owner

@sam-goodwin sam-goodwin commented Aug 2, 2022

Fixes #373

Adds a new NodeKind, QuasiString, to represent the raw strings in a TemplateExpr and TaggedTemplateExpr:

const a = `quasi string ${expr}`
// parses as
new TemplateExpr(new Quasi("quasi string "), new Identifier("expr"))

@netlify
Copy link

netlify bot commented Aug 2, 2022

Deploy Preview for effortless-malabi-1c3e77 ready!

Name Link
🔨 Latest commit 1d6068a
🔍 Latest deploy log https://app.netlify.com/sites/effortless-malabi-1c3e77/deploys/62e97efd6f066900089d37ef
😎 Deploy Preview https://deploy-preview-375--effortless-malabi-1c3e77.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sam-goodwin sam-goodwin requested a review from thantos August 2, 2022 07:19
@sam-goodwin sam-goodwin self-assigned this Aug 2, 2022
@thantos
Copy link
Collaborator

thantos commented Aug 2, 2022

@sam-goodwin
Copy link
Owner Author

Missing: https://github.com/fuctionless/functionless/blob/main/src/checker.ts#L846

I don't understand the use-case?

@sam-goodwin
Copy link
Owner Author

@sam-goodwin sam-goodwin merged commit caadfd6 into main Aug 2, 2022
@sam-goodwin sam-goodwin deleted the samg-template-expr branch August 2, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove ambiguity from TemplateExpr and TaggedTemplateExpr

3 participants