-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smbtorture output #44
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
depends on PR #42 |
🎉 All dependencies have been resolved ! |
synarete
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (but see one minor string-formatting comment).
At the moment we print output only in cases of failure. Change this to output for all results. Signed-off-by: Sachin Prabhu <sp@spui.uk>
6e741be
to
3368294
Compare
anoopcs9
reviewed
Nov 17, 2023
anoopcs9
approved these changes
Nov 17, 2023
anoopcs9
added a commit
to anoopcs9/sit-environment
that referenced
this pull request
Nov 21, 2023
This reverts commit 96a70e4. * smbtorture tests have been configured[1] to print the results irrespective of the outcome. * Test output is now redirected to a separate file[2], additional debug lines from ansible are no longer required. [1] samba-in-kubernetes/sit-test-cases#44 [2] samba-in-kubernetes/sit-test-cases#46 Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
anoopcs9
added a commit
to anoopcs9/sit-environment
that referenced
this pull request
Nov 21, 2023
* smbtorture tests have been configured[1] to print the results irrespective of the outcome. * Test output is now redirected to a separate file[2], additional debug lines from ansible are no longer required. [1] samba-in-kubernetes/sit-test-cases#44 [2] samba-in-kubernetes#67 Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
anoopcs9
added a commit
to anoopcs9/sit-environment
that referenced
this pull request
Nov 21, 2023
* smbtorture tests have been configured[1] to print the results irrespective of the outcome. * Test output is now redirected to a separate file[2], additional debug lines from ansible are no longer required. [1] samba-in-kubernetes/sit-test-cases#44 [2] samba-in-kubernetes#67 Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
anoopcs9
added a commit
to anoopcs9/sit-environment
that referenced
this pull request
Nov 22, 2023
* smbtorture tests have been configured[1] to print the results irrespective of the outcome. * Test output is now redirected to a separate file[2], additional debug lines from ansible are no longer required. Changes to Makefile is basically the revert of 15b8f61. [1] samba-in-kubernetes/sit-test-cases#44 [2] samba-in-kubernetes#67 Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
anoopcs9
added a commit
to anoopcs9/sit-environment
that referenced
this pull request
Nov 22, 2023
* smbtorture tests have been configured[1] to print the results irrespective of the outcome. * Test output is now redirected to a separate file[2], additional debug lines from ansible are no longer required. Previous change from 15b8f61 to configure ANSIBLE_STDOUT_CALLBACK option can also be avoided as entire results are now available in a separate file. [1] samba-in-kubernetes/sit-test-cases#44 [2] samba-in-kubernetes#67 Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
anoopcs9
added a commit
to anoopcs9/sit-environment
that referenced
this pull request
Nov 23, 2023
* smbtorture tests have been configured[1] to print the results irrespective of the outcome. * Test output is now redirected to a separate file[2], additional debug lines from ansible are no longer required. Previous change from 15b8f61 to configure ANSIBLE_STDOUT_CALLBACK option can also be avoided as entire results are now available in a separate file. [1] samba-in-kubernetes/sit-test-cases#44 [2] samba-in-kubernetes#67 Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
anoopcs9
added a commit
to samba-in-kubernetes/sit-environment
that referenced
this pull request
Nov 23, 2023
* smbtorture tests have been configured[1] to print the results irrespective of the outcome. * Test output is now redirected to a separate file[2], additional debug lines from ansible are no longer required. Previous change from 15b8f61 to configure ANSIBLE_STDOUT_CALLBACK option can also be avoided as entire results are now available in a separate file. [1] samba-in-kubernetes/sit-test-cases#44 [2] #67 Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current smbtorture tests report output only in case of test failures. This behaviour was a result of the earlier test runner we used. With pytest we no longer need to worry about managing the output.
depends on #42