Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smbtorture output #44

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

spuiuk
Copy link
Collaborator

@spuiuk spuiuk commented Nov 14, 2023

The current smbtorture tests report output only in case of test failures. This behaviour was a result of the earlier test runner we used. With pytest we no longer need to worry about managing the output.

depends on #42

@spuiuk
Copy link
Collaborator Author

spuiuk commented Nov 14, 2023

depends on PR #42

Copy link

dpulls bot commented Nov 15, 2023

🎉 All dependencies have been resolved !

Copy link
Collaborator

@synarete synarete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but see one minor string-formatting comment).

At the moment we print output only in cases of failure. Change this to
output for all results.

Signed-off-by: Sachin Prabhu <sp@spui.uk>
@spuiuk spuiuk merged commit 8764af1 into samba-in-kubernetes:main Nov 17, 2023
anoopcs9 added a commit to anoopcs9/sit-environment that referenced this pull request Nov 21, 2023
This reverts commit 96a70e4.

* smbtorture tests have been configured[1] to print the results
  irrespective of the outcome.
* Test output is now redirected to a separate file[2], additional
  debug lines from ansible are no longer required.

[1] samba-in-kubernetes/sit-test-cases#44
[2] samba-in-kubernetes/sit-test-cases#46

Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
anoopcs9 added a commit to anoopcs9/sit-environment that referenced this pull request Nov 21, 2023
* smbtorture tests have been configured[1] to print the results
  irrespective of the outcome.
* Test output is now redirected to a separate file[2], additional
  debug lines from ansible are no longer required.

[1] samba-in-kubernetes/sit-test-cases#44
[2] samba-in-kubernetes#67

Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
anoopcs9 added a commit to anoopcs9/sit-environment that referenced this pull request Nov 21, 2023
* smbtorture tests have been configured[1] to print the results
  irrespective of the outcome.
* Test output is now redirected to a separate file[2], additional
  debug lines from ansible are no longer required.

[1] samba-in-kubernetes/sit-test-cases#44
[2] samba-in-kubernetes#67

Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
anoopcs9 added a commit to anoopcs9/sit-environment that referenced this pull request Nov 22, 2023
* smbtorture tests have been configured[1] to print the results
  irrespective of the outcome.
* Test output is now redirected to a separate file[2], additional
  debug lines from ansible are no longer required.

Changes to Makefile is basically the revert of 15b8f61.

[1] samba-in-kubernetes/sit-test-cases#44
[2] samba-in-kubernetes#67

Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
anoopcs9 added a commit to anoopcs9/sit-environment that referenced this pull request Nov 22, 2023
* smbtorture tests have been configured[1] to print the results
  irrespective of the outcome.
* Test output is now redirected to a separate file[2], additional
  debug lines from ansible are no longer required.

Previous change from 15b8f61 to
configure ANSIBLE_STDOUT_CALLBACK option can also be avoided as
entire results are now available in a separate file.

[1] samba-in-kubernetes/sit-test-cases#44
[2] samba-in-kubernetes#67

Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
anoopcs9 added a commit to anoopcs9/sit-environment that referenced this pull request Nov 23, 2023
* smbtorture tests have been configured[1] to print the results
  irrespective of the outcome.
* Test output is now redirected to a separate file[2], additional
  debug lines from ansible are no longer required.

Previous change from 15b8f61 to
configure ANSIBLE_STDOUT_CALLBACK option can also be avoided as
entire results are now available in a separate file.

[1] samba-in-kubernetes/sit-test-cases#44
[2] samba-in-kubernetes#67

Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
anoopcs9 added a commit to samba-in-kubernetes/sit-environment that referenced this pull request Nov 23, 2023
* smbtorture tests have been configured[1] to print the results
  irrespective of the outcome.
* Test output is now redirected to a separate file[2], additional
  debug lines from ansible are no longer required.

Previous change from 15b8f61 to
configure ANSIBLE_STDOUT_CALLBACK option can also be avoided as
entire results are now available in a separate file.

[1] samba-in-kubernetes/sit-test-cases#44
[2] #67

Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants