Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Redirect tox output to a file #46

Closed

Conversation

anoopcs9
Copy link
Collaborator

No description provided.

Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
anoopcs9 added a commit to anoopcs9/sit-environment that referenced this pull request Nov 21, 2023
This reverts commit 96a70e4.

* smbtorture tests have been configured[1] to print the results
  irrespective of the outcome.
* Test output is now redirected to a separate file[2], additional
  debug lines from ansible are no longer required.

[1] samba-in-kubernetes/sit-test-cases#44
[2] samba-in-kubernetes/sit-test-cases#46

Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
@anoopcs9 anoopcs9 requested a review from spuiuk November 21, 2023 06:37
@spuiuk
Copy link
Collaborator

spuiuk commented Nov 21, 2023

Shouldn't this be handled in the sit-environment instead where we store the output into a file which is then copied over. So the output file is both created and consumed by sit-environment.

I would like to see the output shown to the user running sit-test-cases manually. If the redirection has to be done in this repository then I would like to see it pass through tee so that we see the output on both the console and the log file.

@spuiuk
Copy link
Collaborator

spuiuk commented Nov 21, 2023

I am curious as to why the centos/xfs test is failing. In this case, because the output is in the log file and the artifact is not shown yet, we can determine what the cause of the failure is. I think we can look at the other PRs for this.

@anoopcs9
Copy link
Collaborator Author

Shouldn't this be handled in the sit-environment instead where we store the output into a file which is then copied over. So the output file is both created and consumed by sit-environment.

I would like to see the output shown to the user running sit-test-cases manually. If the redirection has to be done in this repository then I would like to see it pass through tee so that we see the output on both the console and the log file.

Fine.

@anoopcs9 anoopcs9 closed this Nov 21, 2023
@anoopcs9 anoopcs9 deleted the redirect-tox-out-file branch November 21, 2023 13:29
@anoopcs9
Copy link
Collaborator Author

Closed in favour of samba-in-kubernetes/sit-environment#67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants