Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring IIIF Content Search into Transcript Component #502

Closed
6 tasks done
joncameron opened this issue May 20, 2024 · 7 comments
Closed
6 tasks done

Bring IIIF Content Search into Transcript Component #502

joncameron opened this issue May 20, 2024 · 7 comments
Assignees

Comments

@joncameron
Copy link
Contributor

joncameron commented May 20, 2024

Description

Intermediate functionality is needed to convert our Content Search API-based search responses to the format implemented by Third Wave in the Transcript component. For this issue, transcript component architecture isn't as important since the bulk of this work will be on parsing. Discussion of transcript component architecture can come after this work.

Done Looks Like

  • Parse the search service in the manifest
  • Pass search service into the search as a Matcher Factory when search functionality is called
  • Convert IIIF content search response into format that can be parsed by the search within component
  • Transcript search returns search results for all existing transcripts for current canvas.
  • Drop-down to select transcript shows # of hits in each transcript (like Aviary)
  • Searches submitted from the transcript search box on a media item should be submitted as phrase searches and only produce phrase matches in the transcript(s).
@joncameron
Copy link
Contributor Author

Description

The way search is written, we may need intermediate functionality to convert search responses to the format implemented by Third Wave in the Transcript component.

There are 2 ways to use the API: to use the props, and to pass the search service in the parser and pass that on. We probably would go with the latter (parsing), and we'll need a ticket to parse the search service in the manifest and pass that into the search as a Matcher Factory to call it when searching is happening in the UI.

@joncameron
Copy link
Contributor Author

joncameron commented May 20, 2024

Other thing: does the Transcript component need to be independent still? If so, we may need to change code; Patrick has pulled the component under the overall state which will complicate standalone usage. We should have a discussion on this: what are our needs? Do we need to keep it any particular way? Ideally it would be possible to use the Transcript component independently.

@joncameron
Copy link
Contributor Author

See #502 for discussion of retaining independence for the Transcript component.

@elynema
Copy link

elynema commented Jun 26, 2024

@Dananji I'm seeing an issue with this example record: https://avalon-dev.dlib.indiana.edu/media_objects/gf06g267d. I don't know if it's related to re-formatting the IIIF content search or if it's related to displaying search results.

For the first section, if I go to the transcript tab and search 'Isaac' I get no results, even though Isaac is clearly in the first few lines of the transcript. The underlying IIIF content search is providing a result, but it's not getting shown in the front-end.

@elynema
Copy link

elynema commented Jun 26, 2024

Same issue when I search 'depaul' or 'university' in this transcript. Hits are not being shown in the interface. I am not seeing this issue in other sections on this record so not sure if it is related to the transcript or section in particular.

@elynema
Copy link

elynema commented Jun 26, 2024

In addition, if I submit a search, and then select a new section, the search carries over. This would be fine if the search re-sets itself to the new transcript, but it seems to retain the number of hits from the previous transcript, and it is also carrying over the cue with the active hit from the prior transcript and displaying it at the top of the new section's transcript.

image.png

@elynema
Copy link

elynema commented Jun 28, 2024

Basic issues reported here are resolved across Safari, Chrome, Android, iOS. Closing this and opening some new issues.

@elynema elynema closed this as completed Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants