-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring IIIF Content Search into Transcript Component #502
Comments
DescriptionThe way search is written, we may need intermediate functionality to convert search responses to the format implemented by Third Wave in the Transcript component. There are 2 ways to use the API: to use the props, and to pass the search service in the parser and pass that on. We probably would go with the latter (parsing), and we'll need a ticket to parse the search service in the manifest and pass that into the search as a Matcher Factory to call it when searching is happening in the UI. |
Other thing: does the Transcript component need to be independent still? If so, we may need to change code; Patrick has pulled the component under the overall state which will complicate standalone usage. We should have a discussion on this: what are our needs? Do we need to keep it any particular way? Ideally it would be possible to use the Transcript component independently. |
See #502 for discussion of retaining independence for the Transcript component. |
@Dananji I'm seeing an issue with this example record: https://avalon-dev.dlib.indiana.edu/media_objects/gf06g267d. I don't know if it's related to re-formatting the IIIF content search or if it's related to displaying search results. For the first section, if I go to the transcript tab and search 'Isaac' I get no results, even though Isaac is clearly in the first few lines of the transcript. The underlying IIIF content search is providing a result, but it's not getting shown in the front-end. |
Same issue when I search 'depaul' or 'university' in this transcript. Hits are not being shown in the interface. I am not seeing this issue in other sections on this record so not sure if it is related to the transcript or section in particular. |
In addition, if I submit a search, and then select a new section, the search carries over. This would be fine if the search re-sets itself to the new transcript, but it seems to retain the number of hits from the previous transcript, and it is also carrying over the cue with the active hit from the prior transcript and displaying it at the top of the new section's transcript. |
Basic issues reported here are resolved across Safari, Chrome, Android, iOS. Closing this and opening some new issues. |
Description
Intermediate functionality is needed to convert our Content Search API-based search responses to the format implemented by Third Wave in the Transcript component. For this issue, transcript component architecture isn't as important since the bulk of this work will be on parsing. Discussion of transcript component architecture can come after this work.
Done Looks Like
The text was updated successfully, but these errors were encountered: