Content search #515
Merged
Content search #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcolvar
approved these changes
Jun 7, 2024
| @@ -102,6 +102,8 @@ export const TranscriptSearch = ({ | |||
| onClick={() => { | |||
| setSearchQuery(null); | |||
| if (searchInputRef.current) searchInputRef.current.value = ''; | |||
| // Set focus to the search input field | |||
| searchInputRef.current.focus(); | |||
Comment on lines
+192
to
+198
| setSearchResults(searchResults); | ||
| if (hitCounts?.length > 0) { | ||
| setSearchResults({ | ||
| ...searchResults, | ||
| counts: hitCounts, | ||
| }); | ||
| } |
There was a problem hiding this comment.
Why does setSearchResults get called twice when there are hitCounts? Wouldn't it be simpler to conditionally add hitCounts to searchResults and then call setSearchResults once?
|
Merging this now so we can test and continue work on it this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #502 #508
Please feel free to make changes as needed and then, squash and merge once again it's ready.