Don't skip reject_if when _destroy is passed #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nested attributes was previously skiping the check of the reject_if proc if the _destroy flag was passed. This was occuring when allow_destroy was false, so the record was getting created. Thanks to @ojlyytinen for finding this bug and the orignal work on PR #879 from which this PR is inspired.
jcoyne
force-pushed
the
nested_attrs_destroy
branch
from
aaa97bf
to
50dffb9
Compare
mjgiarlo
added a commit
that referenced
this pull request
Sep 25, 2015
Don't skip reject_if when _destroy is passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested attributes was previously skiping the check of the reject_if proc
if the _destroy flag was passed. This was occuring when allow_destroy
was false, so the record was getting updated. Thanks to @ojlyytinen for
finding this bug and the orignal work on PR #879 from which this PR is
inspired.