Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't skip reject_if when _destroy is passed #900

Merged
merged 2 commits into from
Sep 25, 2015
Merged

Don't skip reject_if when _destroy is passed #900

merged 2 commits into from
Sep 25, 2015

Commits on Sep 25, 2015

  1. Don't skip reject_if when _destroy is passed 

    Nested attributes was previously skiping the check of the reject_if proc
if the _destroy flag was passed. This was occuring when allow_destroy
was false, so the record was getting created. Thanks to @ojlyytinen for
finding this bug and the orignal work on PR #879 from which this PR is
inspired.
    @jcoyne
    jcoyne committed Sep 25, 2015
    Configuration menu
    Copy the full SHA
    e78160c View commit details
    Browse the repository at this point in the history

  2. Refactor nested_attribute test for easier reading

    @jcoyne
    jcoyne committed Sep 25, 2015
    Configuration menu
    Copy the full SHA
    50dffb9 View commit details
    Browse the repository at this point in the history