Upgrade to Rubocop 1.x #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcolvar
force-pushed
the
rubocop1-redux
branch
3 times, most recently
from
6e1f214
to
0deb410
Compare
bess
previously approved these changes
Mar 15, 2022
cjcolvar
force-pushed
the
rubocop1-redux
branch
from
0deb410
to
6c06c60
Compare
|
@bess I rebased this to get the latest from main. Do you mind re-reviewing it? (I don't think anything should have changed.) |
bess
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reopens #57 and adds another commit that adjusts the thresholds of 3 cops and a configuration option of another based upon running the original PR against Hyrax's main branch (see https://gist.github.com/cjcolvar/4185fa40bd88ac7ec2203d1a78c94bd2 and samvera/hyrax#5478).
This change would probably be a major release given the upgrade of rubocop, the dropping of ruby 2.4, and the fact that downstream repos will probably have to fix some autocorrectable violations when upgrading.