Upgrade to Bixby 4.0.0 #5478
Merged
Upgrade to Bixby 4.0.0 #5478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elrayle
reviewed
Mar 2, 2022
There was a problem hiding this comment.
Taking a quick look, it looks like 26 or the 32 files are trivial auto-changes that don't change behavior. If we are definitely adopting cops that want those changes and they are compatible with current Bixby, it would be great to get those in as a separate PR. That PR would be super simple to review. And then this PR would only have changes that need a deeper review.
cjcolvar
force-pushed
the
bixby_rubocop1
branch
2 times, most recently
from
5a8271c
to
eb88938
Compare
|
@elrayle I'm not sure how to do that since rubocop would fail without both pieces present. I could make an upgrade PR which adds exceptions for all of the auto-correctable violations then I could fix them in a separate PR. Do you think that makes sense to do? |
no-reply
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress waiting on samvera/bixby#65 and a release of bixby.This PR upgrades hyrax to the 4.0.0 release of bixby which uses rubocop 1.x.