Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ApplicationParser#file_set_entry_class to API #710

Merged
merged 1 commit into from
Jan 16, 2023

Commits on Jan 16, 2023

  1. Adding ApplicationParser#file_set_entry_class to API

    Prior to this commit, this method was not defined on the
    `ApplicationParser` yet there was an assumption in the
    `Bulkrax::ImportersController` and `Bulkrax::ExportersController` that
    this method existed.
    
    With this commit, we're acknowledging that each parser should implement
    this method.
    
    In addition this commit adds a `#create_file_sets` method for the
    `Bulkrax::XmlParser`.  This change mirrors the
    `Bulkrax::XmlParser#create_collections` implementation and todo item.
    
    A future state that would be wonderful is to create spec helpers that
    implementers could use in their specs to ensure a compliant interface.
    This echoes how Valkyrie does things.
    jeremyf committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    2ef3577 View commit details
    Browse the repository at this point in the history