Adding Bulkrax::EntrySpecHelper
#726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyf
added
enhancement
With this commit, we're introducing
`Bulkrax::EntrySpecHelper.entry_for`, a public api method for downstream
Bulkrax spec support.
**Release Notes**
The newly provided `Bulkrax::EntrySpecHelper.entry_for` method is
intended to provide a consistent mechanism for testing your entry parser
logic without needing to jump through the entire import cycle for that
entry.
To use, will need to explicitly require it in your test suite:
```ruby
require 'bulkrax/entry_spec_helper'
RSpec.describe MyParser do
let(:entry) { Bulkrax::EntrySpecHelper.entry_for(...) }
end
```
Each of the entry types have slightly different parameter requirements
for instantiation. The best source to see those is in Bulkrax's
`./spec/bulkrax/entry_spec_helper_spec.rb` file
Closes: #714
Related to:
- scientist-softserv/adventist-dl#246
- #719
- #705
jeremyf
force-pushed
the
jeremyf-adding-bulkrax-spec-helpers
branch
from
6990127
to
36855e9
Compare
sephirothkod
approved these changes
Feb 3, 2023
jeremyf
added a commit
to scientist-softserv/adventist_knapsack
that referenced
this pull request
Oct 4, 2023
This commit includes two things: 1. Favor Bulkrax::EntrySpecHelper provided by Bulkrax (for which the removed code was a prototype). 2. Use the existing spec to determine what the default work type should be (instead of relying on a random assignment based on the first element of the registered curation concerns) And from this commit, we have a passing test! Related to: - https://github.com/scientist-softserv/adventist-dl/issues/538 - samvera/bulkrax#726 - samvera/bulkrax#719 - samvera/bulkrax#742 - samvera/hyku#1811
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit, we're introducing
Bulkrax::EntrySpecHelper.entry_for, a public api method for downstream Bulkrax spec support.Release Notes
The newly provided
Bulkrax::EntrySpecHelper.entry_formethod is intended to provide a consistent mechanism for testing your entry parser logic without needing to jump through the entire import cycle for that entry.To use, will need to explicitly require it in your test suite:
Each of the entry types have slightly different parameter requirements for instantiation. The best source to see those is in Bulkrax's
./spec/bulkrax/entry_spec_helper_spec.rbfileCloses: #714
Related to:
part_ofmaps only topartproperty scientist-softserv/adventist-dl#246