🎁 Adding indices to Bulkrax Tables #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: this is a best guess of what could use indexing. The guess is based on my recent querying. - `add_index :bulkrax_entries, :identifier` :: because the identifier is an important concept for an import. - `add_index :bulkrax_entries, :type` :: because filtering on the type of an entry is important. - `add_index :bulkrax_entries, [:importerexporter_id, :importerexporter_type], name: 'bulkrax_entries_importerexporter_idx` :: this is a foreign key for the entries relationship to the importer/exporter. - `add_index :bulkrax_pending_relationships, :parent_id` :: a foreign key - `add_index :bulkrax_pending_relationships, :child_id` :: a foreign key - `add_index :bulkrax_statuses, [:statusable_id, :statusable_type], name: 'bulkrax_statuses_statusable_idx'` :: a foreign key - `add_index :bulkrax_statuses, [:runnable_id, :runnable_type], name: 'bulkrax_statuses_runnable_idx'` :: a foreign key - `add_index :bulkrax_statuses, :error_class` :: when querying what's in error, this index is helpful; also one used for grouping.
In downstream implementations, I'm seeing 1.4.0. I'm seeing 1.5.0 failing in specs.
In specs, I was seeing the following error: ``` Psych::AliasesNotEnabled: Cannot load database configuration: Alias parsing was not enabled. To enable it, pass `aliases: true` to `Psych::load` or `Psych::safe_load`. ``` Given that we rarely touch the file, I see no benefit to using an alias relative to the above error exception.
Looking at Adventist, which has a working Redis instance, I see that it uses 4.2.5; however the newer version (v5) has the following error: `ArgumentError: wrong number of arguments (given 1, expected 0)`; that error is part of redis-client which is part of redis 5.0.6
First, this is well past end of life. And second, I'm seeing the following in the 2.6 build: ``` ArgumentError: wrong number of arguments (given 4, expected 1) /home/runner/work/bulkrax/bulkrax/vendor/bundle/ruby/2.6.0/gems/psych-5.1.0/lib/psych.rb:322:in `safe_load' ``` Not interested in fighting against that.
As this is for specs, I'm favoring that functionality/implementation.
I'm seeing the following in CI: ``` ArgumentError: wrong number of arguments (given 4, expected 1) /home/runner/work/bulkrax/bulkrax/vendor/bundle/ruby/2.7.0/gems/psych-5.1.0/lib/psych.rb:322:in `safe_load' ```
jeremyf
force-pushed
the
adding-indices-to-tables
branch
from
cfaee2f
to
5a6ba88
Compare
alishaevn
reviewed
Jun 9, 2023
| @@ -4,22 +4,23 @@ | |||
| # Ensure the SQLite 3 gem is defined in your Gemfile | |||
| # gem 'sqlite3' | |||
| # | |||
| default: &default | |||
There was a problem hiding this comment.
was this not working? or do you just have a preference of explicitly stating the variables for each environment?
There was a problem hiding this comment.
This was not working because of some Psych stuff.
bkiahstroud
reviewed
Jun 9, 2023
bkiahstroud
approved these changes
Jun 9, 2023
alishaevn
approved these changes
Jun 12, 2023
|
consider removing coverage task |
…lkrax into adding-indices-to-tables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is a best guess of what could use indexing. The guess is based on my recent querying.
add_index :bulkrax_entries, :identifier:: because the identifier is an important concept for an import.add_index :bulkrax_entries, :type:: because filtering on the type of an entry is important.add_index :bulkrax_entries, [:importerexporter_id, :importerexporter_type], name: 'bulkrax_entries_importerexporter_idx:: this is a foreign key for the entries relationship to the importer/exporter.add_index :bulkrax_pending_relationships, :parent_id:: a foreign keyadd_index :bulkrax_pending_relationships, :child_id:: a foreign keyadd_index :bulkrax_statuses, [:statusable_id, :statusable_type], name: 'bulkrax_statuses_statusable_idx':: a foreign keyadd_index :bulkrax_statuses, [:runnable_id, :runnable_type], name: 'bulkrax_statuses_runnable_idx':: a foreign keyadd_index :bulkrax_statuses, :error_class:: when querying what's in error, this index is helpful; also one used for grouping.