Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎁 Adding indices to Bulkrax Tables #813

Merged
merged 11 commits into from
Jun 14, 2023
Merged

Commits on Jun 8, 2023

  1. 🎁 Adding indices to Bulkrax Tables

    Note: this is a best guess of what could use indexing.  The guess is
    based on my recent querying.
    
    - `add_index :bulkrax_entries, :identifier` :: because the identifier is
      an important concept for an import.
    - `add_index :bulkrax_entries, :type` :: because filtering on the type
      of an entry is important.
    - `add_index :bulkrax_entries, [:importerexporter_id,
      :importerexporter_type], name: 'bulkrax_entries_importerexporter_idx` :: this is a foreign key for the entries
      relationship to the importer/exporter.
    
    - `add_index :bulkrax_pending_relationships, :parent_id` :: a foreign key
    - `add_index :bulkrax_pending_relationships, :child_id`  :: a foreign key
    
    - `add_index :bulkrax_statuses, [:statusable_id, :statusable_type],
      name: 'bulkrax_statuses_statusable_idx'` :: a foreign key
    - `add_index :bulkrax_statuses, [:runnable_id, :runnable_type], name:
      'bulkrax_statuses_runnable_idx'` :: a foreign key
    - `add_index :bulkrax_statuses, :error_class` :: when querying what's in
      error, this index is helpful; also one used for grouping.
    jeremyf committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    b2006d5 View commit details
    Browse the repository at this point in the history
  2. ⚙️ Pinning to more specific version of dry-monads

    In downstream implementations, I'm seeing 1.4.0.  I'm seeing 1.5.0
    failing in specs.
    jeremyf committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    4e9eff4 View commit details
    Browse the repository at this point in the history
  3. ⚙️ Removing yaml aliases from test database config

    In specs, I was seeing the following error:
    
    ```
    Psych::AliasesNotEnabled: Cannot load database configuration: Alias
    parsing was not enabled. To enable it, pass `aliases: true` to
    `Psych::load` or `Psych::safe_load`.
    ```
    
    Given that we rarely touch the file, I see no benefit to using an alias
    relative to the above error exception.
    jeremyf committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    bb2e916 View commit details
    Browse the repository at this point in the history
  4. ⚙️ Tightening Redis Dependency for Tests

    Looking at Adventist, which has a working Redis instance, I see that it
    uses 4.2.5; however the newer version (v5) has the following error:
    
    `ArgumentError: wrong number of arguments (given 1, expected 0)`; that
    error is part of redis-client which is part of redis 5.0.6
    jeremyf committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    edf6804 View commit details
    Browse the repository at this point in the history
  5. 🤖 Removing the 2.6 tests

    First, this is well past end of life.  And second, I'm seeing the
    following in the 2.6 build:
    
    ```
    ArgumentError: wrong number of arguments (given 4, expected 1)
    /home/runner/work/bulkrax/bulkrax/vendor/bundle/ruby/2.6.0/gems/psych-5.1.0/lib/psych.rb:322:in
    `safe_load'
    ```
    
    Not interested in fighting against that.
    jeremyf committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    692ec46 View commit details
    Browse the repository at this point in the history
  6. 🤖 Favoring redis_config from downstream application

    As this is for specs, I'm favoring that functionality/implementation.
    jeremyf committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    0588f0e View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. 🤖 Pinning dev version of Psych

    I'm seeing the following in CI:
    
    ```
    ArgumentError: wrong number of arguments (given 4, expected 1)
    /home/runner/work/bulkrax/bulkrax/vendor/bundle/ruby/2.7.0/gems/psych-5.1.0/lib/psych.rb:322:in
    `safe_load'
    ```
    jeremyf committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    5a6ba88 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Configuration menu
    Copy the full SHA
    0782ede View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fbb387f View commit details
    Browse the repository at this point in the history
  3. Merge branch 'adding-indices-to-tables' of github.com:samvera-labs/bu…

    …lkrax into adding-indices-to-tables
    ShanaLMoore committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    69bffef View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    993e11f View commit details
    Browse the repository at this point in the history