-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎁 Adding indices to Bulkrax Tables #813
Commits on Jun 8, 2023
-
🎁 Adding indices to Bulkrax Tables
Note: this is a best guess of what could use indexing. The guess is based on my recent querying. - `add_index :bulkrax_entries, :identifier` :: because the identifier is an important concept for an import. - `add_index :bulkrax_entries, :type` :: because filtering on the type of an entry is important. - `add_index :bulkrax_entries, [:importerexporter_id, :importerexporter_type], name: 'bulkrax_entries_importerexporter_idx` :: this is a foreign key for the entries relationship to the importer/exporter. - `add_index :bulkrax_pending_relationships, :parent_id` :: a foreign key - `add_index :bulkrax_pending_relationships, :child_id` :: a foreign key - `add_index :bulkrax_statuses, [:statusable_id, :statusable_type], name: 'bulkrax_statuses_statusable_idx'` :: a foreign key - `add_index :bulkrax_statuses, [:runnable_id, :runnable_type], name: 'bulkrax_statuses_runnable_idx'` :: a foreign key - `add_index :bulkrax_statuses, :error_class` :: when querying what's in error, this index is helpful; also one used for grouping.
Configuration menu - View commit details
-
Copy full SHA for b2006d5 - Browse repository at this point
Copy the full SHA b2006d5View commit details -
⚙️ Pinning to more specific version of dry-monads
In downstream implementations, I'm seeing 1.4.0. I'm seeing 1.5.0 failing in specs.
Configuration menu - View commit details
-
Copy full SHA for 4e9eff4 - Browse repository at this point
Copy the full SHA 4e9eff4View commit details -
⚙️ Removing yaml aliases from test database config
In specs, I was seeing the following error: ``` Psych::AliasesNotEnabled: Cannot load database configuration: Alias parsing was not enabled. To enable it, pass `aliases: true` to `Psych::load` or `Psych::safe_load`. ``` Given that we rarely touch the file, I see no benefit to using an alias relative to the above error exception.
Configuration menu - View commit details
-
Copy full SHA for bb2e916 - Browse repository at this point
Copy the full SHA bb2e916View commit details -
⚙️ Tightening Redis Dependency for Tests
Looking at Adventist, which has a working Redis instance, I see that it uses 4.2.5; however the newer version (v5) has the following error: `ArgumentError: wrong number of arguments (given 1, expected 0)`; that error is part of redis-client which is part of redis 5.0.6
Configuration menu - View commit details
-
Copy full SHA for edf6804 - Browse repository at this point
Copy the full SHA edf6804View commit details -
First, this is well past end of life. And second, I'm seeing the following in the 2.6 build: ``` ArgumentError: wrong number of arguments (given 4, expected 1) /home/runner/work/bulkrax/bulkrax/vendor/bundle/ruby/2.6.0/gems/psych-5.1.0/lib/psych.rb:322:in `safe_load' ``` Not interested in fighting against that.
Configuration menu - View commit details
-
Copy full SHA for 692ec46 - Browse repository at this point
Copy the full SHA 692ec46View commit details -
🤖 Favoring redis_config from downstream application
As this is for specs, I'm favoring that functionality/implementation.
Configuration menu - View commit details
-
Copy full SHA for 0588f0e - Browse repository at this point
Copy the full SHA 0588f0eView commit details
Commits on Jun 9, 2023
-
🤖 Pinning dev version of Psych
I'm seeing the following in CI: ``` ArgumentError: wrong number of arguments (given 4, expected 1) /home/runner/work/bulkrax/bulkrax/vendor/bundle/ruby/2.7.0/gems/psych-5.1.0/lib/psych.rb:322:in `safe_load' ```
Configuration menu - View commit details
-
Copy full SHA for 5a6ba88 - Browse repository at this point
Copy the full SHA 5a6ba88View commit details
Commits on Jun 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0782ede - Browse repository at this point
Copy the full SHA 0782edeView commit details -
Configuration menu - View commit details
-
Copy full SHA for fbb387f - Browse repository at this point
Copy the full SHA fbb387fView commit details -
Merge branch 'adding-indices-to-tables' of github.com:samvera-labs/bu…
…lkrax into adding-indices-to-tables
Configuration menu - View commit details
-
Copy full SHA for 69bffef - Browse repository at this point
Copy the full SHA 69bffefView commit details -
Configuration menu - View commit details
-
Copy full SHA for 993e11f - Browse repository at this point
Copy the full SHA 993e11fView commit details