add option to support good job for background jobs instead of sidekiq #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amvera/hyku into mr_good_job_its_got_to_be_good
houndci-bot
reviewed
Sep 22, 2023
|
This endpoint is working for adventist_knapsack (which should be using good_jobs instead of sidekiq), however revoking my approval until we we also manually test this by creating a work with an attachment. The HOUND issues will get corrected once this branch gets updates from main.
|
ShanaLMoore
approved these changes
Sep 25, 2023
|
This looks fine on Adventist knapsack but I wasn't able to get good jobs' jobs running. The jobs would queue in the terminal, but even w the worker container running they were not moving or showing up in the good_job dashboard. When I switched the env var to sidekiq, everything worked fine. Testing this branch now to isolate if it's an adventist_knapsack problem or not. cc @orangewolf |
ShanaLMoore
requested changes
Sep 28, 2023
This commit adds a conditional to run the correct command for sidekiq or good_job, when running docker compose up.
…amvera/hyku into mr_good_job_its_got_to_be_good
|
@ShanaLMoore do you agree this is working now? |
|
this got merged some other way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.