Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎁 Add conditional to run correct command for worker #10

Closed
wants to merge 1 commit into from

Conversation

ShanaLMoore
Copy link
Contributor

This commit adds a conditional to run the correct command for sidekiq or good_job, when running docker compose up.

This commit adds a conditional to run the correct command for sidekiq or good_job, when running docker compose up.
Copy link
Contributor

@laritakr laritakr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be in Hyku rather than the knapsack?

Or maybe both places... I'm not sure how much it can use from Hyku's setup.

@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Sep 28, 2023

@laritakr good point, I'll make a commit to hyku's WIP PR instead: samvera/hyku#1997

@ShanaLMoore ShanaLMoore deleted the docker-update-good-job-command branch October 2, 2023 16:36
ShanaLMoore pushed a commit that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants