☄️ Valkyrize Hyku EPIC #2129

ShanaLMoore · 2024-01-04T22:28:19Z

Standing branch to begin epic:

☄️ EPIC: Valkyrize Hyku scientist-softserv/hykuup_knapsack#35

Included

🎁 Make generic work and image resource (use valkyrie resource generator, make sure name ends in resource) scientist-softserv/hykuup_knapsack#80

houndci-bot · 2024-01-05T20:15:09Z

app/assets/javascripts/admin_color_select.js

+    allColorInputs.each(function() {
+      $(this).val($(this).data('default-value'))
+    })
+  })


Missing semicolon.

houndci-bot · 2024-01-05T20:15:09Z

app/assets/javascripts/admin_color_select.js

+
+    allColorInputs.each(function() {
+      $(this).val($(this).data('default-value'))
+    })


Missing semicolon.

houndci-bot · 2024-01-05T20:15:09Z

app/assets/javascripts/admin_color_select.js

+    var allColorInputs = $("input[name*='color']")
+
+    allColorInputs.each(function() {
+      $(this).val($(this).data('default-value'))


Missing semicolon.

houndci-bot · 2024-01-05T20:15:10Z

app/assets/javascripts/admin_color_select.js

+  $('.panel-footer a.restore-all-default-colors').click(function(e) {
+    e.preventDefault()
+
+    var allColorInputs = $("input[name*='color']")


Missing semicolon.

houndci-bot · 2024-01-05T20:15:10Z

app/assets/javascripts/admin_color_select.js

+  })
+
+  $('.panel-footer a.restore-all-default-colors').click(function(e) {
+    e.preventDefault()


Missing semicolon.

houndci-bot · 2024-01-05T20:15:10Z

app/assets/javascripts/admin_color_select.js

+    var input = $("input[name='admin_appearance["+ defaultTarget +"]']")
+
+    input.val(input.data('default-value'))
+  })


Missing semicolon.

houndci-bot · 2024-01-05T20:15:10Z

app/assets/javascripts/admin_color_select.js

+    var defaultTarget = $(e.target).data('default-target')
+    var input = $("input[name='admin_appearance["+ defaultTarget +"]']")
+
+    input.val(input.data('default-value'))


Missing semicolon.

houndci-bot · 2024-01-05T20:15:10Z

app/assets/javascripts/admin_color_select.js

+    e.preventDefault()
+
+    var defaultTarget = $(e.target).data('default-target')
+    var input = $("input[name='admin_appearance["+ defaultTarget +"]']")


Missing semicolon.

houndci-bot · 2024-01-05T20:15:10Z

app/assets/javascripts/admin_color_select.js

+  $('div.defaultable-colors a.restore-default-color').click(function(e) {
+    e.preventDefault()
+
+    var defaultTarget = $(e.target).data('default-target')


Missing semicolon.

houndci-bot · 2024-01-05T20:15:10Z

app/assets/javascripts/admin_color_select.js

@@ -0,0 +1,20 @@
+$(document).on('turbolinks:load', function() {
+  $('div.defaultable-colors a.restore-default-color').click(function(e) {
+    e.preventDefault()


Missing semicolon.

houndci-bot · 2024-01-05T20:15:10Z

app/assets/javascripts/admin_color_select.js

+    allColorInputs.each(function() {
+      $(this).val($(this).data('default-value'))
+    })
+  })


Missing semicolon.

houndci-bot · 2024-01-05T20:15:10Z

app/assets/javascripts/admin_color_select.js

+
+    allColorInputs.each(function() {
+      $(this).val($(this).data('default-value'))
+    })


Missing semicolon.

houndci-bot · 2024-01-05T20:15:10Z

app/assets/javascripts/admin_color_select.js

+    var allColorInputs = $("input[name*='color']")
+
+    allColorInputs.each(function() {
+      $(this).val($(this).data('default-value'))


Missing semicolon.

houndci-bot · 2024-01-05T20:15:10Z

app/assets/javascripts/admin_color_select.js

+  $('.panel-footer a.restore-all-default-colors').click(function(e) {
+    e.preventDefault()
+
+    var allColorInputs = $("input[name*='color']")


Missing semicolon.

houndci-bot · 2024-01-05T20:15:10Z

app/assets/javascripts/admin_color_select.js

+  })
+
+  $('.panel-footer a.restore-all-default-colors').click(function(e) {
+    e.preventDefault()


Missing semicolon.

houndci-bot · 2024-01-05T20:15:10Z

app/assets/javascripts/admin_color_select.js

+    var input = $("input[name='admin_appearance["+ defaultTarget +"]']")
+
+    input.val(input.data('default-value'))
+  })


Missing semicolon.

houndci-bot · 2024-01-05T20:15:10Z

app/assets/javascripts/admin_color_select.js

+    var defaultTarget = $(e.target).data('default-target')
+    var input = $("input[name='admin_appearance["+ defaultTarget +"]']")
+
+    input.val(input.data('default-value'))


Missing semicolon.

houndci-bot · 2024-01-05T20:15:10Z

app/assets/javascripts/admin_color_select.js

+    e.preventDefault()
+
+    var defaultTarget = $(e.target).data('default-target')
+    var input = $("input[name='admin_appearance["+ defaultTarget +"]']")


Missing semicolon.

houndci-bot · 2024-01-05T20:15:10Z

app/assets/javascripts/admin_color_select.js

+  $('div.defaultable-colors a.restore-default-color').click(function(e) {
+    e.preventDefault()
+
+    var defaultTarget = $(e.target).data('default-target')


Missing semicolon.

houndci-bot · 2024-01-05T20:15:10Z

app/assets/javascripts/admin_color_select.js

@@ -0,0 +1,20 @@
+$(document).on('turbolinks:load', function() {
+  $('div.defaultable-colors a.restore-default-color').click(function(e) {
+    e.preventDefault()


Missing semicolon.

houndci-bot · 2024-01-05T20:15:10Z

app/assets/javascripts/admin_color_select.js

+    allColorInputs.each(function() {
+      $(this).val($(this).data('default-value'))
+    })
+  })


Missing semicolon.

houndci-bot · 2024-01-05T20:15:10Z

app/assets/javascripts/admin_color_select.js

+
+    allColorInputs.each(function() {
+      $(this).val($(this).data('default-value'))
+    })


Missing semicolon.

houndci-bot · 2024-01-05T20:15:10Z

app/assets/javascripts/admin_color_select.js

+    var allColorInputs = $("input[name*='color']")
+
+    allColorInputs.each(function() {
+      $(this).val($(this).data('default-value'))


Missing semicolon.

houndci-bot · 2024-01-05T20:15:11Z

app/assets/javascripts/admin_color_select.js

+  $('.panel-footer a.restore-all-default-colors').click(function(e) {
+    e.preventDefault()
+
+    var allColorInputs = $("input[name*='color']")


Missing semicolon.

houndci-bot · 2024-01-05T20:15:11Z

app/assets/javascripts/admin_color_select.js

+  })
+
+  $('.panel-footer a.restore-all-default-colors').click(function(e) {
+    e.preventDefault()


Missing semicolon.

houndci-bot · 2024-01-05T20:15:11Z

app/assets/javascripts/blacklight_range_limit/range_limit_distro_facets.js

+    if (domDependenciesMet()) {
+      // Grab the data from the ul div
+      var series_data = new Array();
+      var pointer_lookup = new Array();


The array literal notation [] is preferable.

houndci-bot · 2024-01-05T20:15:11Z

app/assets/javascripts/blacklight_range_limit/range_limit_distro_facets.js

+    //flot loaded? And canvas element supported.
+    if (domDependenciesMet()) {
+      // Grab the data from the ul div
+      var series_data = new Array();


The array literal notation [] is preferable.

houndci-bot · 2024-01-05T20:15:11Z

app/assets/javascripts/blacklight_range_limit/range_limit_shared.js

+  };
+
+  global.BlacklightRangeLimit = BlacklightRangeLimit;
+}(this);


Expected an assignment or function call and instead saw an expression.

houndci-bot · 2024-01-05T20:15:12Z

app/assets/javascripts/blacklight_range_limit/range_limit_slider.js

+        max = BlacklightRangeLimit.parseNum($(range_element).find(".max").first().text());
+     }
+
+     return [min, max]


Missing semicolon.

houndci-bot · 2024-01-05T20:15:12Z

app/assets/javascripts/blacklight_range_limit/range_limit_slider.js

+
+
+
+     var min = max = BlacklightRangeLimit.parseNum(current_limit.find(".single").text())


Missing semicolon.
You might be leaking a variable (max) here.

houndci-bot · 2024-01-05T20:15:11Z

app/assets/javascripts/admin_color_select.js

+    allColorInputs.each(function() {
+      $(this).val($(this).data('default-value'))
+    })
+  })


Missing semicolon.

houndci-bot · 2024-01-05T20:15:11Z

app/assets/javascripts/admin_color_select.js

+
+    allColorInputs.each(function() {
+      $(this).val($(this).data('default-value'))
+    })


Missing semicolon.

houndci-bot · 2024-01-05T20:15:11Z

app/assets/javascripts/admin_color_select.js

+    var allColorInputs = $("input[name*='color']")
+
+    allColorInputs.each(function() {
+      $(this).val($(this).data('default-value'))


Missing semicolon.

houndci-bot · 2024-01-05T20:15:11Z

app/assets/javascripts/admin_color_select.js

+  $('.panel-footer a.restore-all-default-colors').click(function(e) {
+    e.preventDefault()
+
+    var allColorInputs = $("input[name*='color']")


Missing semicolon.

houndci-bot · 2024-01-05T20:15:11Z

app/assets/javascripts/admin_color_select.js

+  })
+
+  $('.panel-footer a.restore-all-default-colors').click(function(e) {
+    e.preventDefault()


Missing semicolon.

houndci-bot · 2024-01-05T20:15:12Z

app/assets/javascripts/blacklight_range_limit/range_limit_distro_facets.js

+    if (domDependenciesMet()) {
+      // Grab the data from the ul div
+      var series_data = new Array();
+      var pointer_lookup = new Array();


The array literal notation [] is preferable.

houndci-bot · 2024-01-05T20:15:12Z

app/assets/javascripts/blacklight_range_limit/range_limit_distro_facets.js

+    //flot loaded? And canvas element supported.
+    if (domDependenciesMet()) {
+      // Grab the data from the ul div
+      var series_data = new Array();


The array literal notation [] is preferable.

houndci-bot · 2024-01-05T20:15:12Z

app/assets/javascripts/blacklight_range_limit/range_limit_shared.js

+  };
+
+  global.BlacklightRangeLimit = BlacklightRangeLimit;
+}(this);


Expected an assignment or function call and instead saw an expression.

houndci-bot · 2024-01-05T20:15:12Z

app/assets/javascripts/blacklight_range_limit/range_limit_slider.js

+        max = BlacklightRangeLimit.parseNum($(range_element).find(".max").first().text());
+     }
+
+     return [min, max]


Missing semicolon.

houndci-bot · 2024-01-05T20:15:12Z

app/assets/javascripts/blacklight_range_limit/range_limit_slider.js

+
+
+
+     var min = max = BlacklightRangeLimit.parseNum(current_limit.find(".single").text())


Missing semicolon.
You might be leaking a variable (max) here.

houndci-bot · 2024-01-05T20:15:12Z

app/assets/javascripts/blacklight_range_limit/range_limit_distro_facets.js

+      // Grab the data from the ul div
+      var series_data = new Array();
+      var pointer_lookup = new Array();
+      var x_ticks = new Array();


The array literal notation [] is preferable.

houndci-bot · 2024-01-05T20:15:12Z

app/assets/javascripts/blacklight_range_limit/range_limit_distro_facets.js

+    if (domDependenciesMet()) {
+      // Grab the data from the ul div
+      var series_data = new Array();
+      var pointer_lookup = new Array();


The array literal notation [] is preferable.

houndci-bot · 2024-01-05T20:15:12Z

app/assets/javascripts/blacklight_range_limit/range_limit_distro_facets.js

+    //flot loaded? And canvas element supported.
+    if (domDependenciesMet()) {
+      // Grab the data from the ul div
+      var series_data = new Array();


The array literal notation [] is preferable.

houndci-bot · 2024-01-05T20:15:12Z

app/assets/javascripts/blacklight_range_limit/range_limit_shared.js

+  };
+
+  global.BlacklightRangeLimit = BlacklightRangeLimit;
+}(this);


Expected an assignment or function call and instead saw an expression.

houndci-bot · 2024-01-05T20:15:12Z

app/assets/javascripts/blacklight_range_limit/range_limit_slider.js

+        max = BlacklightRangeLimit.parseNum($(range_element).find(".max").first().text());
+     }
+
+     return [min, max]


Missing semicolon.

houndci-bot · 2024-01-05T20:15:12Z

app/assets/javascripts/blacklight_range_limit/range_limit_slider.js

+     }
+
+    begin_el.val(min);
+    end_el.val(max);


'end_el' used out of scope.

houndci-bot · 2024-01-05T20:15:13Z

app/assets/javascripts/blacklight_range_limit/range_limit_slider.js

+       });
+     }
+
+    begin_el.val(min);


'begin_el' used out of scope.

houndci-bot · 2024-01-05T20:15:13Z

app/assets/javascripts/blacklight_range_limit/range_limit_slider.js

+
+       // Slider change should update text input values.
+       var parent = $(this).parent();
+       var form = $(parent).closest(".limit_content").find("form.range_limit");


'form' is already defined.

houndci-bot · 2024-01-05T20:15:13Z

app/assets/javascripts/blacklight_range_limit/range_limit_slider.js

+
+        if (plot && slider_el) { 
+          slider_el.width(plot.width());
+          slider_el.css("display", "block")


Missing semicolon.

houndci-bot · 2024-01-05T20:15:13Z

app/assets/javascripts/blacklight_range_limit/range_limit_slider.js

+     if (isInt(min) && isInt(max)) {
+       $(this).contents().wrapAll('<div style="display:none" />');
+
+       var range_element = $(this);


'range_element' is already defined.

houndci-bot · 2024-01-11T16:17:56Z

app/assets/stylesheets/hyku.scss

 }

 .hyc-banner {
  padding: 15px;
-  .hyc-bugs .hyc-created-by, .hyc-bugs .hyc-last-updated, .hyc-title {
+  .hyc-bugs .hyc-created-by,


Rule declaration should be preceded by an empty line

houndci-bot · 2024-01-11T16:17:56Z

app/assets/stylesheets/hyrax.scss

@@ -22,6 +22,6 @@

 // for catalog search result snippets
 .highlight {
-  background: yellow;
+    background: #ffff00;


Line should be indented 2 spaces, but was indented 4 spaces

Having this file was causing double rendering of bulkrax links in the sidebar. Issues: - #1850 - scientist-softserv/hykuup_knapsack#111

Update bulkrax to point to hyrax-4-valkyrie-support

This commit will adjust for the changes introduced in this commit: samvera/hyrax@8fc0894

bulrax_identifier is not a required property. Each client should set their desired source_identifier in their application. Issue: - scientist-softserv/hykuup_knapsack#136

This commit will add a decorator to check the `human_readable_type` of the given object is a Valkyrie migration object (which by convention ends with 'resource') and adjust the generated link accordingly. For example, a GenericWorkResource should generate links like `/concern/generic_work_resources/...` instead of `/concern/generic_works/...`. The models were updated to include the Hyrax::NestedWorks so the `Attach Child` button would populate the appropriate work types. Lastly, the `Gemfile.lock` was updated to include the latest version of Hyrax `double_combo` branch.

For us to leverage the useful shared specs of Hyrax, we need a test adapter.

…ifier-to-bulkrax I903 remove bulkrax_identifier dependency

Using 'human_readable_type' was going to be flemsy. Instead we are opting for adding the `valkyrie_bsi` to the index and asking that.

…tion

The featured works and collections had some funky css problems where it made sorting them impossible. This commit will override some Hyrax scss and fix some css classes on partials to make the featured works/collections a better user experience.

houndci-bot · 2024-03-29T17:54:35Z

app/assets/stylesheets/hyku.scss

+  background: #ddd;
+  background: -webkit-linear-gradient(top, #ddd 0%, #bbb 100%);
+  background:    -moz-linear-gradient(top, #ddd 0%, #bbb 100%);
+  background:         linear-gradient(top, #ddd 0%, #bbb 100%);


Property background already defined on line 479

houndci-bot · 2024-03-29T17:54:35Z

app/assets/stylesheets/hyku.scss

+.dd3-handle {
+  position: absolute; margin: 0; left: 0; top: 0; cursor: pointer; width: 30px;
+  text-indent: 100px;
+  white-space: nowrap; overflow: hidden;


Property 'overflow' should be placed on own line

houndci-bot · 2024-03-29T17:54:35Z

app/assets/stylesheets/hyku.scss

@@ -467,6 +471,24 @@ body.public-facing {
  padding: 0;
 }

+.dd3-handle {
+  position: absolute; margin: 0; left: 0; top: 0; cursor: pointer; width: 30px;


Properties should be ordered background, border, border-bottom-right-radius, border-top-right-radius, cursor, left, margin, overflow, position, text-indent, top, white-space, width, z-index
Property 'cursor' should be placed on own line
Property 'left' should be placed on own line
Property 'margin' should be placed on own line
Property 'top' should be placed on own line
Property 'width' should be placed on own line

houndci-bot · 2024-03-29T17:54:35Z

app/assets/stylesheets/hyku.scss

@@ -467,6 +471,24 @@ body.public-facing {
  padding: 0;
 }

+.dd3-handle {


Rule set contains (17/10) properties

Fixes bug deleting works & file sets. Refs scientist-softserv/hykuup_knapsack#187

laritakr · 2024-03-29T21:31:19Z

config/application.rb

@@ -178,9 +205,12 @@ def self.path_for(relative_path)
      end
    end

-    config.to_prepare do
-      DerivativeRodeo::Generators::HocrGenerator.additional_tessearct_options = nil
+    config.before_initialize do


I am a bit confused why we declare the models here as well as in hyrax.rb. Which one ultimately controls the behavior? It might be helpful to have it documented why we declare them twice.

This particular commit was me attempting to squash flakey specs. I don't know if they are necessary. And I'll remove and see.

In the `double_combo` branch, we replaced the need for delegation with method_missing. Thus we can remove the delegate declarations and instead rely on method missing behavior.

app/forms/hyrax/forms/admin/appearance_decorator.rb

Addresses all reindex jobs to ensure that they will work for either valkyrie or active fedora objects. Ensures that works and collections are appropriately reindexed as default work and collection images are added OR removed (previously, reindexing didn't occur with removal of default images, resulting in works displaying with a missing image.)

…into i35-valkyrize-hyku

Since we changed the SolrEndpoint, this spec was failing. This change should fix it.

This commit will add storage/files as a persisted volume for rancher set ups. Hyrax uses this directory to store the binaries.

orangewolf

Only the tiniest of questions and comments on this. really excellent work here

orangewolf · 2024-04-02T16:41:15Z

Gemfile.lock

@@ -100,6 +100,9 @@ GIT
  specs:
    hyku_knapsack (0.0.1)
      rails (>= 5.2.0)
+      sentry-rails


how did sentry become a hyku dependency?

should it not be? We added sentry for hyku up knapsack and knapsack prime, but now that you question it I wonder if we should've added it to bundler.d instead (within each repo)?

TODO: rip it out of hyku and put it in bundler.d of the respective repo.

This appears to have come about because we added sentry (et al) to the gem spec of knapsack; and when we bundled along came sentry. This is definitely a surprise as we think about traditional directional dependencies; that is we think of Knapsack as laying on top of Hyku; but in reality it's a much more convoluted relationship.

orangewolf · 2024-04-02T16:50:24Z

app/models/generic_work.rb

-      pdf_splitter_service: IiifPrint::TenantConfig::PdfSplitter
-    )
-  end
+  include IiifPrint.model_configuration(


does this mean we no longer allow IiifPrint on and off?

Yes…except that each tenant can disable it via a feature.

orangewolf · 2024-04-02T17:59:16Z

lib/tasks/index.rake

@@ -26,6 +26,8 @@ task index_collections: :environment do
  end
 end

+# TODO: handle valkyrie reindex once admin sets have been valkyrized


aren't adminsets valkyrized now?

Pushed a PR for this.

#2174 (review)

orangewolf · 2024-04-02T17:59:45Z

lib/wings/services/custom_queries/find_ids_by_model_decorator.rb

@@ -20,7 +20,7 @@ def find_ids_by_model(model:, ids: :all) # rubocop:disable Metrics/MethodLength
        model_name = ModelRegistry.lookup(model).model_name

        solr_query = "_query_:\"{!raw f=has_model_ssim}#{model_name}\""
-        solr_response = ActiveFedora::SolrService.post(solr_query, fl: 'id', rows: @query_rows)['response']
+        solr_response = Hyrax::SolrService.post(solr_query, fl: 'id', rows: @query_rows)['response']


we made a generic service accessor for SolrService above - should we use it here?

I'm not aware of a generic service accessor. Which one were you thinking? There's a lot of Hyrax::SolrService references.

orangewolf · 2024-04-02T18:00:14Z

ops/iiif.tmpl.yaml

@@ -32,6 +32,9 @@ extraVolumeMounts: &volMounts
  - name: uploads


this file seems unused?

There's seems to be a valid host: hyku-iiif.$BASE_URL

that correlates to a running rancher pod:

Related to: - #2129

Base automatically changed from hyrax-5-upgrade to main January 5, 2024 18:12

houndci-bot reviewed Jan 5, 2024

View reviewed changes

ShanaLMoore changed the title ~~🎁 Generate GenericWorkResource and ImageResource~~ 🎁 Valkyrize Hyku EPIC Jan 5, 2024

houndci-bot reviewed Jan 11, 2024

View reviewed changes

ShanaLMoore changed the title ~~🎁 Valkyrize Hyku EPIC~~ ☄️ Valkyrize Hyku EPIC Jan 15, 2024

jeremyf added the major-ver for release notes label Jan 16, 2024

ShanaLMoore had a problem deploying to staging January 17, 2024 22:54 — with GitHub Actions Failure

ShanaLMoore had a problem deploying to staging January 17, 2024 22:56 — with GitHub Actions Failure

ShanaLMoore had a problem deploying to staging January 17, 2024 22:58 — with GitHub Actions Error

ShanaLMoore had a problem deploying to staging January 23, 2024 17:02 — with GitHub Actions Failure

ShanaLMoore had a problem deploying to staging January 23, 2024 17:10 — with GitHub Actions Error

ShanaLMoore temporarily deployed to staging January 23, 2024 19:29 — with GitHub Actions Inactive

ShanaLMoore temporarily deployed to staging January 23, 2024 19:54 — with GitHub Actions Inactive

ShanaLMoore and others added 13 commits January 26, 2024 14:14

Delete _repository_content.html.erb

28e31ae

Having this file was causing double rendering of bulkrax links in the sidebar. Issues: - #1850 - scientist-softserv/hykuup_knapsack#111

use hyrax-4-valkyrie-support bulkrax branch

963fda8

Update bulkrax to point to hyrax-4-valkyrie-support

🐛 App was not loading after updating Hyrax

db7e39d

This commit will adjust for the changes introduced in this commit: samvera/hyrax@8fc0894

⚙️ Don't remove backtrace in dev

44aa7f7

remove bulkrax_identifier from Hyku

887fbf2

bulrax_identifier is not a required property. Each client should set their desired source_identifier in their application. Issue: - scientist-softserv/hykuup_knapsack#136

🧹 Add Valkyrie test adapter

c7ac8d6

For us to leverage the useful shared specs of Hyrax, we need a test adapter.

🧹 Always with the coppers

89d0c59

Merge pull request #2158 from samvera/i903-move-find-by-bulkrax-ident…

9be2b81

…ifier-to-bulkrax I903 remove bulkrax_identifier dependency

Updating Hyrax to latest version

e05e5c1

🧹 Rework logic for #hydra_model

fc72267

Using 'human_readable_type' was going to be flemsy. Instead we are opting for adding the `valkyrie_bsi` to the index and asking that.

Merge branch 'i35-valkyrize-hyku' into i35-valkyrize-hyku-link-genera…

670784d

…tion

📚 Add docs regarding knapsack

4622fa8

houndci-bot reviewed Mar 29, 2024

View reviewed changes

Update IiifPrint (#2172)

75a9d99

Fixes bug deleting works & file sets. Refs scientist-softserv/hykuup_knapsack#187

laritakr reviewed Mar 29, 2024

View reviewed changes

jeremyf added 2 commits April 1, 2024 09:48

♻️ Favor method_missing over delegation

65c9abb

In the `double_combo` branch, we replaced the need for delegation with method_missing. Thus we can remove the delegate declarations and instead rely on method missing behavior.

♻️ Remove config that was there for flakey tests

fb6adf7

jeremyf reviewed Apr 1, 2024

View reviewed changes

app/forms/hyrax/forms/admin/appearance_decorator.rb Outdated Show resolved Hide resolved

jeremyf and others added 12 commits April 1, 2024 10:29

Update app/forms/hyrax/forms/admin/appearance_decorator.rb

5e97d78

Favor published valkyrie gem version

5b61235

update gemfile to add support for sentry

5a90fcf

🗡 Stab in the dark at fixing an intermittent bug

2ec7b41

add conditional to support HykuUp Knapsack specs

a8c49fd

add conditional to support HykuUp Knapsack specs

8cf0e95

Merge branch 'i35-valkyrize-hyku' of https://github.com/samvera/hyku …

ad48579

…into i35-valkyrize-hyku

💄 rubocop fix

f745207

💄 rubocop fix

289ca62

Merge branch 'i35-valkyrize-hyku' of https://github.com/samvera/hyku …

08779c1

…into i35-valkyrize-hyku

🧹 Add core to hash in spec

19e5f3a

Since we changed the SolrEndpoint, this spec was failing. This change should fix it.

ShanaLMoore requested a review from orangewolf April 2, 2024 14:37

kirkkwang added 3 commits April 2, 2024 08:47

🧹 Add storage/files as a persisted volumn

25f22cc

This commit will add storage/files as a persisted volume for rancher set ups. Hyrax uses this directory to store the binaries.

update bulkrax, hyrax, iiif_print

a19960f

bump to rc3

8e390ee

jeremyf approved these changes Apr 2, 2024

View reviewed changes

kirkkwang approved these changes Apr 2, 2024

View reviewed changes

laritakr approved these changes Apr 2, 2024

View reviewed changes

laritakr merged commit ca49a19 into main Apr 2, 2024
4 checks passed

orangewolf approved these changes Apr 2, 2024

View reviewed changes

jeremyf added a commit that referenced this pull request Apr 2, 2024

📚 Remove completed TODO item

7bad7ce

Related to: - #2129

jeremyf mentioned this pull request Apr 2, 2024

📚 Remove completed TODO item #2174

Merged




		var min = max = BlacklightRangeLimit.parseNum(current_limit.find(".single").text())

		@@ -32,6 +32,9 @@ extraVolumeMounts: &volMounts
		- name: uploads

☄️ Valkyrize Hyku EPIC #2129

☄️ Valkyrize Hyku EPIC #2129

Conversation

ShanaLMoore commented Jan 4, 2024 • edited Loading

Included

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

orangewolf left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ShanaLMoore Apr 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ShanaLMoore commented Jan 4, 2024 •

edited

Loading

ShanaLMoore Apr 2, 2024 •

edited

Loading