-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎁 1019 batch email notifications #2200
Merged
Merged
Commits on May 1, 2024
-
🎁 Flesh out
BatchEmailNotificationJob
This commit fleshes out the `BatchEmailNotificationJob` and adds a preview for the email that will be sent.
Configuration menu - View commit details
-
Copy full SHA for b2e8a22 - Browse repository at this point
Copy the full SHA b2e8a22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09ec444 - Browse repository at this point
Copy the full SHA 09ec444View commit details -
Configuration menu - View commit details
-
Copy full SHA for ddbcc91 - Browse repository at this point
Copy the full SHA ddbcc91View commit details -
Add
BatchEmailNotificationJob
to create_accountThis commit adds the new job to the queue whenever a new tenant is created. Also adding a method to the `User` model to mark all undelivered emails as delivered when their batch email frequency is changed to 'off'.
Configuration menu - View commit details
-
Copy full SHA for 26317d8 - Browse repository at this point
Copy the full SHA 26317d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cd003c - Browse repository at this point
Copy the full SHA 6cd003cView commit details -
Change default value for batch_email_frequency
The prior default value of `off` appears to be a reserved term and did not work for i18n translations.
Configuration menu - View commit details
-
Copy full SHA for 643d55f - Browse repository at this point
Copy the full SHA 643d55fView commit details -
- Show email frequency on user profile - Add selection list to edit profile menu to update frequency - Add appropriate translations to en.yml Ref: scientist-softserv/palni-palci#1022
Configuration menu - View commit details
-
Copy full SHA for 0861258 - Browse repository at this point
Copy the full SHA 0861258View commit details -
Configuration menu - View commit details
-
Copy full SHA for 519522b - Browse repository at this point
Copy the full SHA 519522bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 23924e7 - Browse repository at this point
Copy the full SHA 23924e7View commit details
Commits on May 2, 2024
-
This commit will ensure the correct bootstrap class is on the batch email frequency select box. It will also use the font awesome calendar icon for the label.
Configuration menu - View commit details
-
Copy full SHA for 3666922 - Browse repository at this point
Copy the full SHA 3666922View commit details -
Since it seems 'off' was protected, we switched to 'never' instead, this commit will clean up any other places where it was set to 'off'.
Configuration menu - View commit details
-
Copy full SHA for b4cabac - Browse repository at this point
Copy the full SHA b4cabacView commit details -
Add callback for
Mailboxer::Receipt
This commit will add a callback for `Mailboxer::Receipt` to mark the receipt as delivered if the user set their batch_email_frequency to 'never'.
Configuration menu - View commit details
-
Copy full SHA for d7c4b94 - Browse repository at this point
Copy the full SHA d7c4b94View commit details -
✅ Add specs for batch email notifications
This commit will add a few specs and also redo the logic for the batch email notification send frequency. We needed a migration to the users model to track when the last email was sent to check if it's time to send another one based on their batch_email_frequency setting.
Configuration menu - View commit details
-
Copy full SHA for 7c0c652 - Browse repository at this point
Copy the full SHA 7c0c652View commit details
Commits on May 3, 2024
-
This commit runs the Google translations for i18n files.
Configuration menu - View commit details
-
Copy full SHA for bc7e324 - Browse repository at this point
Copy the full SHA bc7e324View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04e61ff - Browse repository at this point
Copy the full SHA 04e61ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 19a6e4e - Browse repository at this point
Copy the full SHA 19a6e4eView commit details
Commits on May 6, 2024
-
Add Site's application name into email
This commit will add the Site's application name into the email subject as well as the body.
Configuration menu - View commit details
-
Copy full SHA for c0d6351 - Browse repository at this point
Copy the full SHA c0d6351View commit details -
Configuration menu - View commit details
-
Copy full SHA for f3740c6 - Browse repository at this point
Copy the full SHA f3740c6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.