Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hyrax && remove moved code #2382

Merged
merged 6 commits into from
Nov 15, 2024
Merged

Update hyrax && remove moved code #2382

merged 6 commits into from
Nov 15, 2024

Conversation

ShanaLMoore
Copy link
Collaborator

@ShanaLMoore ShanaLMoore commented Nov 14, 2024

pulls in ref:

move valkyrie resource migration code from hyku to hyrax (https://github.com/samvera/hyrax/pull/6973)
* move valkyrie resource migration code from hyku to hyrax
* prevent works from becoming inaccessible during valkyrie transition
* more cross compatible fix for collection thumbnail issue
* make adminset wings identifiable

TODO:

Remove duplicate code now that it lives in Hyrax

@ShanaLMoore ShanaLMoore added the ignore-for-release ignore this for release notes label Nov 14, 2024
this was a lint failure in main
@@ -50,7 +50,7 @@
config.force_ssl = true
config.ssl_options = {
redirect: {
Copy link
Collaborator Author

@ShanaLMoore ShanaLMoore Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrects a lint failure in main

laritakr
laritakr previously approved these changes Nov 14, 2024
@laritakr
Copy link
Collaborator

Needs subsequent Hyku work to remove the now-duplicated code that was added to Hyrax.

@ShanaLMoore ShanaLMoore marked this pull request as draft November 14, 2024 20:12
Copy link

github-actions bot commented Nov 14, 2024

Test Results

    3 files  ±0      3 suites  ±0   17m 50s ⏱️ -8s
2 040 tests  - 2  1 990 ✅  - 1  50 💤 ±0  0 ❌  - 1 
2 067 runs   - 2  2 015 ✅  - 1  52 💤 ±0  0 ❌  - 1 

Results for commit 38a32e8. ± Comparison against base commit dd65a0e.

This pull request removes 44 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 0e350dc5-ec33-4f28-affc-04f6fa9e5748
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit bb800076-a05f-475c-a2c1-9dbd26abd0b6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read af6ddd65-4efa-493f-88b5-bbe9b4d2d940
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update b9c36793-a320-4510-9ad4-be28ccbe2248
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 897bc802-0c99-4857-ab87-d40de361c9f1
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 52c9c4e1-b393-4525-a1bb-7d1b971d1f89
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 69867056-69b6-472d-a754-3c797d58e37a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update e9777a06-df56-4a1f-9191-745e1cd02f12
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy cf70e204-beeb-41d1-a65d-e51a36e56bd8
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 8b45bb7b-015b-4177-b465-c177a1d5939d
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy f824447e-f284-435a-a39b-9e83093ec1d6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit cbe27eb0-d71a-4bad-bfc9-89da4715cbc7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read b89818b5-c8ab-4bdb-8872-18878255ab1f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update fb683c99-0731-4de4-b6b3-a384a9ad4609
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy b685cb44-fe42-424b-b875-d1852a60780a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 94520d70-e59b-45b1-b24a-9e1ce7102b12
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 8b5d2dd6-b2d2-4fcd-a0ef-cfb26a244a75
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update c4474797-d926-4908-8d3b-ecfdda550913
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 29a68be6-c2e6-40a6-bcfe-527df4192f34
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit adf923da-5ea1-4a69-94e4-5253cd79838a
…

♻️ This comment has been updated with latest results.

@ShanaLMoore ShanaLMoore changed the title Update hyrax Update hyrax && remove moved code Nov 15, 2024
@laritakr laritakr marked this pull request as ready for review November 15, 2024 19:55
@laritakr laritakr merged commit 2ea73b9 into main Nov 15, 2024
8 checks passed
@laritakr laritakr deleted the hyrax-update branch November 15, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release ignore this for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants