[i886] - update logic to fix collection thumbnail bug

[ShanaLMoore]

The default work thumbnail was displaying even though the default collection thumbnail was set.

Issue:

• Default Collection thumbnail bug scientist-softserv/adventist_knapsack#886

When No Collection Branding is Set

When Default Collection Thumbnail is Set

• Collections should render the default thumbnail

When Default Collection Thumbnail is NOT set

• Collections should render Hyrax's default thumbnail

When Collection Branding is Set

When Default Collection Thumbnail is Set

• Collections should render the Branding thumbnail

[github-actions]

Test Results

    3 files  ±0      3 suites  ±0   17m 55s ⏱️ +13s
2 042 tests +2  1 991 ✅ +2  50 💤 ±0  1 ❌ ±0 
2 069 runs  +2  2 016 ✅ +2  52 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit d0a437f. ± Comparison against base commit 8cf3a6f.

This pull request removes 42 and adds 44 tests. Note that renamed tests count towards both.

spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 6df95f38-2284-48dc-90da-74f8e2d534e7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit f5234842-fc4a-4cc0-b259-fa5c45f4a0d0
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read cf13596d-3498-4852-b704-7008dd755a41
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update cdc04d97-794b-47cd-8f67-e2d1262a4206
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 0ee06ccb-f816-41ac-8eb7-c330279d37a5
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit a1b32a54-2dc6-4205-836a-8300338b178e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read eb9e8faf-1b6c-4789-8fee-10c337dec923
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 8fec72d5-e094-404f-8a10-9843653b508a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy a28e5006-8694-4f47-b5bb-84afd1597eba
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 716c1da2-cb5e-4345-a87a-beac86b5f8ca
…

spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 50475075-16f1-40ac-a825-08a45dfddfc6
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit da34dab5-7c33-4eb0-810c-2ac4a4dfcdf7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read ae6b28a3-0924-4a06-817d-7baaae225dab
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 8ca3d0e7-03dc-4b79-a6d0-94f426601b7f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 7a8f5434-8921-4a4b-b585-5ace7a05442a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit a999dfc3-20f9-4100-92e8-fb58dd6191e9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 5134dcfa-f879-41b4-b73a-07d900cd135a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update e2f090ec-d045-44f7-9454-67e7ab3525ba
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 702d95fc-b9e7-4782-9d59-e337de1ffd24
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 8d1658f1-da42-4d9b-8688-07991643a998
…

♻️ This comment has been updated with latest results.

[ShanaLMoore]

The failing specs gets resolved by updating Hyrax. ref: #2382

[ShanaLMoore]

NOTES

This was tested in adventist knapsack as well as hyku demo, and it appears to be working.

As an aside, locally I was getting this error when trying to set a thumbnail in Adventist knapsack, but the same error happened when using main (of both adventist knapsack and hyku). This error does not occur in staging or prod so I'm not sure what this is about.

To reproduce, spin up main Adventist Knapsack. In the submodule check out this branch. Spin the project up, create a collection. Click the branding tab. Upload and save a thumbnail file. 🤔

[ShanaLMoore]

the spec and lint failure are coming from main so I'm going to go ahead and merge this